Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2698843005: cc: Make SingleOnTop strategy reject transformed overlays. (Closed)

Created:
3 years, 10 months ago by Daniele Castagna
Modified:
3 years, 10 months ago
Reviewers:
reveman, dnicoara, halliwell
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make SingleOnTop strategy reject transformed overlays. Currently overlay transforms are ignored by ozone drm platform. This is causing pepper content to be displayed upside down on certain devices. This CL always rejects overlays in SingleOnTop strategy with transform different than identity while we work on supporting the rotation (that can be also used for mirroring) property. Currently OverlayStrategySingleOnTop is used only on drm platforms. BUG=691013 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2698843005 Cr-Commit-Position: refs/heads/master@{#451378} Committed: https://chromium.googlesource.com/chromium/src/+/15d052adb744d524228947248ab96c80b3bdf7ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -8 lines) Patch
M cc/output/overlay_strategy_single_on_top.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/output/overlay_unittest.cc View 8 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Daniele Castagna
3 years, 10 months ago (2017-02-17 18:53:04 UTC) #5
reveman
lgtm
3 years, 10 months ago (2017-02-17 18:58:30 UTC) #6
halliwell
On 2017/02/17 18:58:30, reveman wrote: > lgtm lgtm
3 years, 10 months ago (2017-02-17 19:13:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698843005/1
3 years, 10 months ago (2017-02-17 20:18:29 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 21:05:34 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/15d052adb744d524228947248ab9...

Powered by Google App Engine
This is Rietveld 408576698