Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2698833003: Fix the crash on clicking buttons in Bluetooth system menu in debug build. (Closed)

Created:
3 years, 10 months ago by fukino
Modified:
3 years, 10 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the crash on clicking buttons in Bluetooth system menu in debug build. In https://codereview.chromium.org/2684293002, 'else' before NOTREACHED() was accidentally dropped. It caused the crash on debug build. BUG=686249 TBR=tdanderson@chromium.org TEST=click the toggle button and settings button in debug build. Review-Url: https://codereview.chromium.org/2698833003 Cr-Commit-Position: refs/heads/master@{#450936} Committed: https://chromium.googlesource.com/chromium/src/+/ee70c9cdc585a45d3ba60b6dfcc74e79e99aab70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ash/common/system/chromeos/bluetooth/tray_bluetooth.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
fukino
TBRing tdanderson@ to make the Bluetooth menu working again ASAP in debug build. I'll add ...
3 years, 10 months ago (2017-02-16 11:01:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698833003/1
3 years, 10 months ago (2017-02-16 11:02:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ee70c9cdc585a45d3ba60b6dfcc74e79e99aab70
3 years, 10 months ago (2017-02-16 12:00:39 UTC) #8
tdanderson
3 years, 10 months ago (2017-02-16 19:34:55 UTC) #9
Message was sent while issue was closed.
LGTM thanks for addressing quickly

Powered by Google App Engine
This is Rietveld 408576698