Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2698813007: Fix teardown of stale AudioStreamMonitor poll callbacks. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 9e954d813c5dec1a290def689ce1f51c1f983c6a..9ea129332252f9a3a12efc5e045b68829d5cd4b8 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -4398,6 +4398,7 @@ void WebContentsImpl::RenderViewTerminated(RenderViewHost* rvh,
for (auto& observer : observers_)
observer.RenderProcessGone(GetCrashedStatus());
+ audio_stream_monitor_.RenderProcessGone(rvh->GetProcess()->GetID());
Max Morin 2017/02/17 16:39:53 Actually, this code confuses me. Shouldn't audio_s
DaleCurtis 2017/02/17 17:23:03 Could be, but since WC is the only owner of this c
Charlie Reis 2017/02/17 21:27:55 Yeah, I can see both sides, but I see the argument
DaleCurtis 2017/02/17 22:03:59 Done.
}
void WebContentsImpl::RenderViewDeleted(RenderViewHost* rvh) {

Powered by Google App Engine
This is Rietveld 408576698