Fix teardown of stale AudioStreamMonitor poll callbacks.

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <stddef.h>
 
 #include <cmath>
 #include <utility>
@@ skipping 4380 matching lines @@
   // Reset the loading progress. TODO(avi): What does it mean to have a
   // "renderer crash" when there is more than one renderer process serving a
   // webpage? Once this function is called at a more granular frame level, we
   // probably will need to more granularly reset the state here.
   ResetLoadProgressState();
   NotifyDisconnected();
   SetIsCrashed(status, error_code);
 
   for (auto& observer : observers_)
     observer.RenderProcessGone(GetCrashedStatus());
+  audio_stream_monitor_.RenderProcessGone(rvh->GetProcess()->GetID());

[Max Morin, 2017/02/17 16:39:53]

Actually, this code confuses me. Shouldn't audio_stream_monitor_ be a
RenderProcessHostObserver instead?

[DaleCurtis, 2017/02/17 17:23:03]

Could be, but since WC is the only owner of this class it seemed clearer to have
a single method versus inheriting everything from RPO. Defer to content/ folk on
preference though.

[Charlie Reis, 2017/02/17 21:27:55]

Yeah, I can see both sides, but I see the argument for handling it here.  I'll
suggest moving it up near the other special cases above, like below the
HideValidationMessage call.

[DaleCurtis, 2017/02/17 22:03:59]

Done.

 }
 
 void WebContentsImpl::RenderViewDeleted(RenderViewHost* rvh) {
   for (auto& observer : observers_)
     observer.RenderViewDeleted(rvh);
 }
 
 void WebContentsImpl::UpdateTargetURL(RenderViewHost* render_view_host,
                                       const GURL& url) {
   if (fullscreen_widget_routing_id_ != MSG_ROUTING_NONE) {
@@ skipping 992 matching lines @@
   GetMainFrame()->AddMessageToConsole(
       content::CONSOLE_MESSAGE_LEVEL_WARNING,
       base::StringPrintf("This site does not have a valid SSL "
                          "certificate! Without SSL, your site's and "
                          "visitors' data is vulnerable to theft and "
                          "tampering. Get a valid SSL certificate before"
                          " releasing your website to the public."));
 }
 
 }  // namespace content