Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Issue 2698783002: [DevTools] Make profiles sidebar section non-collapsible. (Closed)

Created:
3 years, 10 months ago by dgozman
Modified:
3 years, 10 months ago
Reviewers:
alph, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Make profiles sidebar section non-collapsible. BUG=691994 Review-Url: https://codereview.chromium.org/2698783002 Cr-Commit-Position: refs/heads/master@{#450927} Committed: https://chromium.googlesource.com/chromium/src/+/58a802887f4c07bb37d25f6d596a44f5d4fb0b7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
dgozman
Could you please take a look?
3 years, 10 months ago (2017-02-15 22:32:00 UTC) #2
pfeldman
lgtm
3 years, 10 months ago (2017-02-15 23:25:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698783002/1
3 years, 10 months ago (2017-02-15 23:26:35 UTC) #6
alph
3 years, 10 months ago (2017-02-15 23:34:47 UTC) #7
alph
lgtm
3 years, 10 months ago (2017-02-15 23:34:48 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on ...
3 years, 10 months ago (2017-02-16 01:29:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698783002/1
3 years, 10 months ago (2017-02-16 01:31:25 UTC) #12
commit-bot: I haz the power
Exceeded global retry quota
3 years, 10 months ago (2017-02-16 04:20:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698783002/1
3 years, 10 months ago (2017-02-16 05:12:38 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 10:43:36 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/58a802887f4c07bb37d25f6d596a...

Powered by Google App Engine
This is Rietveld 408576698