Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2698713003: Remove enabled/set_enabled from DemuxerStream interface (Closed)

Created:
3 years, 10 months ago by servolk
Modified:
3 years, 10 months ago
Reviewers:
slan, xhwang
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, apacible+watch_chromium.org, alokp+watch_chromium.org, darin (slow to review), miu+watch_chromium.org, xjz+watch_chromium.org, erickung+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove enabled/set_enabled from DemuxerStream interface Those methods are only called by various demuxer implementations, there's no need to expose them to all demuxer clients. ChunkDemuxer and FFmpegDemuxer will call those internally when WMPI asks us to change media tracks. Review-Url: https://codereview.chromium.org/2698713003 Cr-Commit-Position: refs/heads/master@{#451057} Committed: https://chromium.googlesource.com/chromium/src/+/675bedf94ebb776c10466ed5b784698e06b1068d

Patch Set 1 #

Patch Set 2 : cast_shell build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -96 lines) Patch
M chromecast/media/cma/base/demuxer_stream_for_test.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chromecast/media/cma/base/demuxer_stream_for_test.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M media/base/demuxer_stream.h View 1 chunk +0 lines, -13 lines 0 comments Download
M media/base/fake_demuxer_stream.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/fake_demuxer_stream.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M media/base/fake_text_track_stream.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/fake_text_track_stream.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M media/base/media_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/mock_filters.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/chunk_demuxer.h View 2 chunks +4 lines, -3 lines 0 comments Download
M media/filters/chunk_demuxer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M media/filters/decrypting_demuxer_stream.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/decrypting_demuxer_stream.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 3 chunks +5 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_adapter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_adapter.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M media/remoting/fake_media_resource.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/remoting/fake_media_resource.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/renderers/renderer_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 18 (12 generated)
servolk
3 years, 10 months ago (2017-02-15 21:49:39 UTC) #7
servolk
On 2017/02/15 21:49:39, servolk wrote: +slan@ for chromecast/
3 years, 10 months ago (2017-02-16 01:22:57 UTC) #11
xhwang
Thank you for the quick follow up! LGTM
3 years, 10 months ago (2017-02-16 03:34:45 UTC) #12
slan
cast rs lgtm
3 years, 10 months ago (2017-02-16 19:17:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698713003/20001
3 years, 10 months ago (2017-02-16 19:20:18 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 19:43:14 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/675bedf94ebb776c10466ed5b784...

Powered by Google App Engine
This is Rietveld 408576698