third_party/WebKit/Source/platform/heap/GCInfo.cpp - Issue 2698673003: Call HeapObjectHeader::checkHeader solely for its side-effect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/GCInfo.cpp

Issue 2698673003: Call HeapObjectHeader::checkHeader solely for its side-effect. (Closed)

Patch Set: Use DCHECK on a bool instead of DCHECK_EQ. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/GCInfo.cpp

diff --git a/third_party/WebKit/Source/platform/heap/GCInfo.cpp b/third_party/WebKit/Source/platform/heap/GCInfo.cpp

index ba69e2a1a5f73ac6512f8b6932ea4690caef7a62..ce0c36c26f30232057cd2054d5877e90cdc2185a 100644

--- a/third_party/WebKit/Source/platform/heap/GCInfo.cpp

+++ b/third_party/WebKit/Source/platform/heap/GCInfo.cpp

@@ -64,7 +64,7 @@ void GCInfoTable::init() {

#if DCHECK_IS_ON()

void assertObjectHasGCInfo(const void* payload, size_t gcInfoIndex) {

- ASSERT(HeapObjectHeader::fromPayload(payload)->checkHeader());

+ HeapObjectHeader::fromPayload(payload)->checkHeader();

#if !defined(COMPONENT_BUILD)

// On component builds we cannot compare the gcInfos as they are statically

// defined in each of the components and hence will not match.