Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: third_party/WebKit/Source/platform/heap/HeapAllocator.h

Issue 2698673003: Call HeapObjectHeader::checkHeader solely for its side-effect. (Closed)
Patch Set: Use DCHECK on a bool instead of DCHECK_EQ. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/HeapAllocator.h
diff --git a/third_party/WebKit/Source/platform/heap/HeapAllocator.h b/third_party/WebKit/Source/platform/heap/HeapAllocator.h
index e05ebb391c9ab62d477a651d606d2f96b7cc27b6..0e7553280ab70aa40d94aa435d0fe6702aad2a38 100644
--- a/third_party/WebKit/Source/platform/heap/HeapAllocator.h
+++ b/third_party/WebKit/Source/platform/heap/HeapAllocator.h
@@ -313,7 +313,7 @@ void HeapVectorBacking<T, Traits>::finalize(void* pointer) {
ASSERT(!WTF::IsTriviallyDestructible<T>::value);
HeapObjectHeader* header = HeapObjectHeader::fromPayload(pointer);
- ASSERT(header->checkHeader());
+ header->checkHeader();
// Use the payload size as recorded by the heap to determine how many
// elements to finalize.
size_t length = header->payloadSize() / sizeof(T);
@@ -342,7 +342,7 @@ void HeapHashTableBacking<Table>::finalize(void* pointer) {
using Value = typename Table::ValueType;
ASSERT(!WTF::IsTriviallyDestructible<Value>::value);
HeapObjectHeader* header = HeapObjectHeader::fromPayload(pointer);
- ASSERT(header->checkHeader());
+ header->checkHeader();
// Use the payload size as recorded by the heap to determine how many
// elements to finalize.
size_t length = header->payloadSize() / sizeof(Value);
« no previous file with comments | « third_party/WebKit/Source/platform/heap/GCInfo.cpp ('k') | third_party/WebKit/Source/platform/heap/HeapAllocator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698