third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2698663003: [css-grid] Improve intrinsic size computation with orthogonal flows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2698663003: [css-grid] Improve intrinsic size computation with orthogonal flows (Closed)

Patch Set: Patch for landing Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 5f4f5758e0fa9f5d417d334b3964da60f1a4635b..08fb319d8b4f63f47c3b0dcb501a3d0e08565d6d 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -2197,7 +2197,8 @@ static bool prepareOrthogonalWritingModeRootForLayout(LayoutObject& root) {

DCHECK(root.isBox() && toLayoutBox(root).isOrthogonalWritingModeRoot());

if (!root.needsLayout() || root.isOutOfFlowPositioned() ||

root.isColumnSpanAll() ||

- !root.styleRef().logicalHeight().isIntrinsicOrAuto())

+ !root.styleRef().logicalHeight().isIntrinsicOrAuto() ||

+ toLayoutBox(root).isGridItem())

return false;

removeFloatingObjectsForSubtreeRoot(root);