Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2698663003: [css-grid] Improve intrinsic size computation with orthogonal flows (Closed)
Patch Set: Patch for landing Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2179 matching lines...) Expand 10 before | Expand all | Expand 10 after
2190 cb->isLayoutBlockFlow()) { 2190 cb->isLayoutBlockFlow()) {
2191 toLayoutBlockFlow(cb)->removeFloatingObjectsFromDescendants(); 2191 toLayoutBlockFlow(cb)->removeFloatingObjectsFromDescendants();
2192 } 2192 }
2193 } 2193 }
2194 } 2194 }
2195 2195
2196 static bool prepareOrthogonalWritingModeRootForLayout(LayoutObject& root) { 2196 static bool prepareOrthogonalWritingModeRootForLayout(LayoutObject& root) {
2197 DCHECK(root.isBox() && toLayoutBox(root).isOrthogonalWritingModeRoot()); 2197 DCHECK(root.isBox() && toLayoutBox(root).isOrthogonalWritingModeRoot());
2198 if (!root.needsLayout() || root.isOutOfFlowPositioned() || 2198 if (!root.needsLayout() || root.isOutOfFlowPositioned() ||
2199 root.isColumnSpanAll() || 2199 root.isColumnSpanAll() ||
2200 !root.styleRef().logicalHeight().isIntrinsicOrAuto()) 2200 !root.styleRef().logicalHeight().isIntrinsicOrAuto() ||
2201 toLayoutBox(root).isGridItem())
2201 return false; 2202 return false;
2202 2203
2203 removeFloatingObjectsForSubtreeRoot(root); 2204 removeFloatingObjectsForSubtreeRoot(root);
2204 return true; 2205 return true;
2205 } 2206 }
2206 2207
2207 void FrameView::layoutOrthogonalWritingModeRoots() { 2208 void FrameView::layoutOrthogonalWritingModeRoots() {
2208 for (auto& root : m_orthogonalWritingModeRootList.ordered()) { 2209 for (auto& root : m_orthogonalWritingModeRootList.ordered()) {
2209 if (prepareOrthogonalWritingModeRootForLayout(*root)) 2210 if (prepareOrthogonalWritingModeRootForLayout(*root))
2210 layoutFromRootObject(*root); 2211 layoutFromRootObject(*root);
(...skipping 3054 matching lines...) Expand 10 before | Expand all | Expand 10 after
5265 void FrameView::setAnimationHost( 5266 void FrameView::setAnimationHost(
5266 std::unique_ptr<CompositorAnimationHost> host) { 5267 std::unique_ptr<CompositorAnimationHost> host) {
5267 m_animationHost = std::move(host); 5268 m_animationHost = std::move(host);
5268 } 5269 }
5269 5270
5270 LayoutUnit FrameView::caretWidth() const { 5271 LayoutUnit FrameView::caretWidth() const {
5271 return LayoutUnit(getHostWindow()->windowToViewportScalar(1)); 5272 return LayoutUnit(getHostWindow()->windowToViewportScalar(1));
5272 } 5273 }
5273 5274
5274 } // namespace blink 5275 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698