Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2698643002: Add data use measurement to DoodleFetcher (Closed)

Created:
3 years, 10 months ago by fhorschig
Modified:
3 years, 10 months ago
Reviewers:
Marc Treib, RyanSturm
CC:
chromium-reviews, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, asvitkine+watch_chromium.org, droger+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add data use measurement to DoodleFetcher In order to track the doodle fetches, introduce a new measurement. BUG=690467 TBR=asvitkine Review-Url: https://codereview.chromium.org/2698643002 Cr-Commit-Position: refs/heads/master@{#451937} Committed: https://chromium.googlesource.com/chromium/src/+/c5b606c3188dac60dd3f8e29bafbb90d95089c3e

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Move ntp_tile DEPS into unrelated CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M components/data_use_measurement/core/data_use_user_data.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/data_use_measurement/core/data_use_user_data.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/doodle/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/doodle/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/doodle/doodle_fetcher.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
fhorschig
Hi Marc, would you please have a look at the follow-up CL for measuring data ...
3 years, 10 months ago (2017-02-21 11:59:39 UTC) #3
Marc Treib
lgtm FYI: Per recent announcement, it's okay to TBR=asvitkine for the histograms.xml change. (You'll still ...
3 years, 10 months ago (2017-02-21 12:17:16 UTC) #4
fhorschig
On 2017/02/21 12:17:16, Marc Treib wrote: > lgtm > > FYI: Per recent announcement, it's ...
3 years, 10 months ago (2017-02-21 13:14:12 UTC) #6
fhorschig
Hi Ryan, Could you please take a look at the enum entry I introduced to ...
3 years, 10 months ago (2017-02-21 13:14:27 UTC) #8
RyanSturm
lgtm
3 years, 10 months ago (2017-02-21 17:47:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698643002/40001
3 years, 10 months ago (2017-02-22 08:38:20 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 08:46:52 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c5b606c3188dac60dd3f8e29bafb...

Powered by Google App Engine
This is Rietveld 408576698