Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2698623004: [Style] Update style of initPartialInterfacesInModules.cpp (Closed)

Created:
3 years, 10 months ago by peria
Modified:
3 years, 10 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update coding style of a generated initPartialInterfacesInModules.cpp This CL does - puts a brace on the same line with the function name. - uses 2 spaces indentation. - removes an empty line between copyright and #include's. There were 2 empty lines. BUG=None Review-Url: https://codereview.chromium.org/2698623004 Cr-Commit-Position: refs/heads/master@{#450930} Committed: https://chromium.googlesource.com/chromium/src/+/e93de4e523999b5f205d0a0bf70ee13e6d8742f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/bindings/scripts/generate_init_partial_interfaces.py View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
peria
PTL. no behavior change.
3 years, 10 months ago (2017-02-16 05:24:35 UTC) #4
Yuki
lgtm
3 years, 10 months ago (2017-02-16 06:21:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698623004/1
3 years, 10 months ago (2017-02-16 06:22:28 UTC) #7
haraken
LGTM
3 years, 10 months ago (2017-02-16 06:50:18 UTC) #8
bashi
lgtm
3 years, 10 months ago (2017-02-16 07:10:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/120340)
3 years, 10 months ago (2017-02-16 08:18:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698623004/1
3 years, 10 months ago (2017-02-16 08:20:33 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/120371)
3 years, 10 months ago (2017-02-16 09:03:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698623004/1
3 years, 10 months ago (2017-02-16 09:20:05 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 11:07:20 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e93de4e523999b5f205d0a0bf70e...

Powered by Google App Engine
This is Rietveld 408576698