Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2698613007: Refactor SRI check in PendingScript::notifyFinished() (Closed)

Created:
3 years, 10 months ago by hiroshige
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -32 lines) Patch
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 2 chunks +45 lines, -32 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (10 generated)
hiroshige
PTAL.
3 years, 10 months ago (2017-02-17 23:18:14 UTC) #5
sof
lgtm
3 years, 10 months ago (2017-02-18 05:58:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698613007/20001
3 years, 10 months ago (2017-02-22 07:34:24 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 09:30:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/48b7863dbfda443885ee2cf2d2c2...

Powered by Google App Engine
This is Rietveld 408576698