MD Settings: Search engines: Fix long name breaking behavior.

MD Settings: Search engines: Fix long name breaking behavior.

BUG=692956
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2698613005
Cr-Commit-Position: refs/heads/master@{#451121}
Committed: https://chromium.googlesource.com/chromium/src/+/da266d3e1f853cac8c2a766bb9b2ebfa0e7eaca3

[dpapad, 2017-02-16 18:02:28]

Description was changed from

==========
MD Settings: Search engines: Fix long name breaking behavior.

BUG=692956
==========

to

==========
MD Settings: Search engines: Fix long name breaking behavior.

BUG=692956
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-16 18:04:04]

dpapad@chromium.org changed reviewers:
+ tommycli@chromium.org

[dpapad, 2017-02-16 18:04:05]

I dropped this attribute in my previous
https://codereview.chromium.org/2693253002/diff/40001/chrome/browser/resource....

[tommycli, 2017-02-16 18:14:55]

whoops lgtm

[dpapad, 2017-02-16 18:15:08]

On 2017/02/16 at 18:14:55, tommycli wrote:
> whoops lgtm

Thanks for the speedy review!

[dpapad, 2017-02-16 18:20:09]

On 2017/02/16 at 18:15:08, dpapad wrote:
> On 2017/02/16 at 18:14:55, tommycli wrote:
> > whoops lgtm
> 
> Thanks for the speedy review!

I had to move the CSS rule, to more accurately match what the old behavior was
doing. The search engine keyword also needs to be broken the same way, see
http://imgur.com/a/C6I5k.

[tommycli, 2017-02-16 18:28:23]

On 2017/02/16 18:20:09, dpapad wrote:
> On 2017/02/16 at 18:15:08, dpapad wrote:
> > On 2017/02/16 at 18:14:55, tommycli wrote:
> > > whoops lgtm
> > 
> > Thanks for the speedy review!
> 
> I had to move the CSS rule, to more accurately match what the old behavior was
> doing. The search engine keyword also needs to be broken the same way, see
> http://imgur.com/a/C6I5k.

no problem

[dpapad, 2017-02-16 18:28:55]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-02-16 18:28:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2698613005/#ps20001
(title: "break word for search engine shortcut too.")

[commit-bot: I haz the power, 2017-02-16 18:29:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 20:42:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 20:42:43]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dpapad, 2017-02-16 21:15:38]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-02-16 21:17:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 22:29:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487279738997800,
"parent_rev": "858b96d1f311506dd39d5a881cfb9fe73cf85b77", "commit_rev":
"da266d3e1f853cac8c2a766bb9b2ebfa0e7eaca3"}

[commit-bot: I haz the power, 2017-02-16 22:29:48]

Description was changed from

==========
MD Settings: Search engines: Fix long name breaking behavior.

BUG=692956
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Search engines: Fix long name breaking behavior.

BUG=692956
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2698613005
Cr-Commit-Position: refs/heads/master@{#451121}
Committed:
https://chromium.googlesource.com/chromium/src/+/da266d3e1f853cac8c2a766bb9b2...
==========

[commit-bot: I haz the power, 2017-02-16 22:29:49]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/da266d3e1f853cac8c2a766bb9b2...