Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Issue 2698583003: Revert of SwiftShader DEPS update (Closed)

Created:
3 years, 10 months ago by dominickn
Modified:
3 years, 10 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of SwiftShader DEPS update (patchset #1 id:1 of https://codereview.chromium.org/2696913002/ ) Reason for revert: This somehow landed. Reverting because it broke the Windows build: https://build.chromium.org/p/chromium/buildstatus?builder=Win&number=51885 Original issue's description: > SwiftShader DEPS update > > This change changes SwiftShader's backend from LLVM to Subzero > on Windows. > > TBR=kbr@chromium.org > TBR_REASON=SwiftShader DEPS roll > BUG=630728 TBR=kbr@chromium.org,sugoi@google.com,sugoi@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630728 Review-Url: https://codereview.chromium.org/2698583003 Cr-Commit-Position: refs/heads/master@{#450553} Committed: https://chromium.googlesource.com/chromium/src/+/551972bc50a7dc29f31d6a91e377488d76cfc549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
dominickn
Created Revert of SwiftShader DEPS update
3 years, 10 months ago (2017-02-15 04:41:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698583003/1
3 years, 10 months ago (2017-02-15 04:42:09 UTC) #3
tzik
On 2017/02/15 04:42:09, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 10 months ago (2017-02-15 04:49:05 UTC) #4
dominickn
On 2017/02/15 04:49:05, tzik wrote: > On 2017/02/15 04:42:09, commit-bot: I haz the power wrote: ...
3 years, 10 months ago (2017-02-15 04:50:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698583003/1
3 years, 10 months ago (2017-02-15 04:51:40 UTC) #9
dominickn
Wait, I think I worked it out. Hopefully that does it.
3 years, 10 months ago (2017-02-15 04:52:02 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 04:52:59 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/551972bc50a7dc29f31d6a91e377...

Powered by Google App Engine
This is Rietveld 408576698