DescriptionRemove unnecessary casts in AudioManagerDeleter on Mac.
The code currently does a const_cast (ewwww), and then a
static_cast<AudioManagerMac*>. The const cast is not needed, since
delete works on const pointers, and the static_cast is not needed
either, since the destructor is virtual so the correct one will be
called either way.
This also means that tests currently invokes undefined behavior when
using ScopedAudioManagerPtr with a mock/fake AudioManager. Oops.
This Cl fixes that.
BUG=693041
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2698503005
Cr-Commit-Position: refs/heads/master@{#451050}
Committed: https://chromium.googlesource.com/chromium/src/+/2fcc731a7f1502b514d622723b7aecd4771ee422
Patch Set 1 #Patch Set 2 : Fix friendship. #
Total comments: 1
Messages
Total messages: 19 (15 generated)
|