Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: components/physical_web/webui/resources/physical_web.html

Issue 2698503004: Add empty list indicator for Physical Web WebUI (Closed)
Patch Set: fix style Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/physical_web/webui/resources/physical_web.html
diff --git a/components/physical_web/webui/resources/physical_web.html b/components/physical_web/webui/resources/physical_web.html
index a5a0ba698842d76e0b2decc0c2242c55fcc6c695..56067dfd4998339d9dbbf35dceae1a0d83ca83ab 100644
--- a/components/physical_web/webui/resources/physical_web.html
+++ b/components/physical_web/webui/resources/physical_web.html
@@ -20,7 +20,7 @@
<script src="chrome://physical-web/strings.js"></script>
</head>
<body>
-<div id="body-container" style="visibility:visible">
+<div id="body-container">
<h1 i18n-content="title"></h1>
@@ -38,6 +38,9 @@
</div>
+<div id="empty-list-container" i18n-content="emptyMessage">
Bernhard Bauer 2017/03/09 09:25:13 I think I would set a `hidden` attribute on this d
mmocny 2017/03/09 15:17:40 I was not previously aware of hidden attribute eve
+</div>
+
<script src="chrome://resources/js/i18n_template.js"></script>
<script src="chrome://resources/js/jstemplate_compiled.js"></script>
</body>
« no previous file with comments | « components/physical_web/webui/resources/physical_web.css ('k') | components/physical_web/webui/resources/physical_web.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698