components/physical_web/webui/resources/physical_web.html - Issue 2698503004: Add empty list indicator for Physical Web WebUI

Side by Side Diff: components/physical_web/webui/resources/physical_web.html

Issue 2698503004: Add empty list indicator for Physical Web WebUI (Closed)

Patch Set: fix style Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html i18n-values="dir:textdirection;lang:language">	2 <html i18n-values="dir:textdirection;lang:language">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title i18n-content="title"></title>	5 <title i18n-content="title"></title>

6 <if expr="is_android or is_ios">	6 <if expr="is_android or is_ios">

7 <meta name="viewport" content="width=device-width, user-scalable=no">	7 <meta name="viewport" content="width=device-width, user-scalable=no">

8 </if>	8 </if>

9 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">	9 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">

10 <link rel="stylesheet" href="chrome://physical-web/physical_web.css">	10 <link rel="stylesheet" href="chrome://physical-web/physical_web.css">

11	11

12 <if expr="is_ios">	12 <if expr="is_ios">

13 <!-- TODO(crbug.com/487000): Remove this once injected by web. -->	13 <!-- TODO(crbug.com/487000): Remove this once injected by web. -->

14 <script src="chrome://resources/js/ios/web_ui.js"></script>	14 <script src="chrome://resources/js/ios/web_ui.js"></script>

15 </if>	15 </if>

16	16

17 <script src="chrome://resources/js/load_time_data.js"></script>	17 <script src="chrome://resources/js/load_time_data.js"></script>

18 <script src="chrome://resources/js/util.js"></script>	18 <script src="chrome://resources/js/util.js"></script>

19 <script src="chrome://physical-web/physical_web.js"></script>	19 <script src="chrome://physical-web/physical_web.js"></script>

20 <script src="chrome://physical-web/strings.js"></script>	20 <script src="chrome://physical-web/strings.js"></script>

21 </head>	21 </head>

22 <body>	22 <body>

23 <div id="body-container" style="visibility:visible">	23 <div id="body-container">

24	24

25 <h1 i18n-content="title"></h1>	25 <h1 i18n-content="title"></h1>

26	26

27 <a class="physicalWebTemplate" id="physicalWebTemplate" jsselect="metadata"	27 <a class="physicalWebTemplate" id="physicalWebTemplate" jsselect="metadata"

28 jsvalues="href:resolvedUrl;onclick:'physicalWebItemClicked(' + index + ')' ">	28 jsvalues="href:resolvedUrl;onclick:'physicalWebItemClicked(' + index + ')' ">

29 <div class="physicalWebIcon">	29 <div class="physicalWebIcon">

30 <img jsvalues="src:pageInfoIcon" />	30 <img jsvalues="src:pageInfoIcon" />

31 </div>	31 </div>

32 <div class="physicalWebText">	32 <div class="physicalWebText">

33 <div class="title" jscontent="pageInfoTitle"></div>	33 <div class="title" jscontent="pageInfoTitle"></div>

34 <div class="resolvedUrl" jscontent="resolvedUrl"></div>	34 <div class="resolvedUrl" jscontent="resolvedUrl"></div>

35 <div class="description" jscontent="pageInfoDescription"></div>	35 <div class="description" jscontent="pageInfoDescription"></div>

36 </div>	36 </div>

37 </a>	37 </a>

38	38

39 </div>	39 </div>

40	40

	41 <div id="empty-list-container" i18n-content="emptyMessage">
	Bernhard Bauer 2017/03/09 09:25:13 I think I would set a `hidden` attribute on this d I think I would set a `hidden` attribute on this div and setting it to false from Javascript as required, instead of adjusting the style. mmocny 2017/03/09 15:17:40 I was not previously aware of hidden attribute eve Show quoted text On 2017/03/09 09:25:13, Bernhard Bauer wrote: > I think I would set a `hidden` attribute on this div and setting it to false > from Javascript as required, instead of adjusting the style. I was not previously aware of hidden attribute even though it seems ancient. Quick SO article (http://stackoverflow.com/questions/6708247/what-is-the-difference-between-the...) search shows there may be advantage to hidden attribute over CSS style, specifically impact on accessiblity features like screenreaders. Interesting!
	42 </div>

	43

41 <script src="chrome://resources/js/i18n_template.js"></script>	44 <script src="chrome://resources/js/i18n_template.js"></script>

42 <script src="chrome://resources/js/jstemplate_compiled.js"></script>	45 <script src="chrome://resources/js/jstemplate_compiled.js"></script>

43 </body>	46 </body>

44 </html>	47 </html>

OLD	NEW