ash/common/system/chromeos/network/network_portal_detector_observer.h - Issue 2698473007: Convert path usage in NetworkListViewBase subclasses to use guids.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/chromeos/network/network_portal_detector_observer.h

Issue 2698473007: Convert path usage in NetworkListViewBase subclasses to use guids. (Closed)

Patch Set: service_path to guid across all of ash Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/common/system/chromeos/network/network_list_view_base.h ('k') | ash/common/system/chromeos/network/network_state_list_detailed_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/common/system/chromeos/network/network_portal_detector_observer.h

diff --git a/ash/common/system/chromeos/network/network_portal_detector_observer.h b/ash/common/system/chromeos/network/network_portal_detector_observer.h

index 6574fb77b75872e3f8ed1f5a735d1a3a1424f34f..da9b5a393ad46af1f592c6da4dc9579bdf7ab329 100644

--- a/ash/common/system/chromeos/network/network_portal_detector_observer.h

+++ b/ash/common/system/chromeos/network/network_portal_detector_observer.h

@@ -14,7 +14,7 @@ class NetworkPortalDetectorObserver {

virtual ~NetworkPortalDetectorObserver() {}

// Called when captive portal is detected for a |network|.

stevenjb 2017/02/16 23:57:48 nit: Fix comment

Ryan Hansberry 2017/02/17 01:43:18 Done.

- virtual void OnCaptivePortalDetected(const std::string& service_path) = 0;

+ virtual void OnCaptivePortalDetected(const std::string& guid) = 0;

};

} // namespace ash