ash/common/system/chromeos/network/network_portal_detector_observer.h - Issue 2698473007: Convert path usage in NetworkListViewBase subclasses to use guids.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/common/system/chromeos/network/network_portal_detector_observer.h

Issue 2698473007: Convert path usage in NetworkListViewBase subclasses to use guids. (Closed)

Patch Set: service_path to guid across all of ash Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ash/common/system/chromeos/network/network_list_view_base.h ('k') | ash/common/system/chromeos/network/network_state_list_detailed_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef ASH_COMMON_SYSTEM_CHROMEOS_NETWORK_NETWORK_PORTAL_DETECTOR_OBSERVER_H_	5 #ifndef ASH_COMMON_SYSTEM_CHROMEOS_NETWORK_NETWORK_PORTAL_DETECTOR_OBSERVER_H_

6 #define ASH_COMMON_SYSTEM_CHROMEOS_NETWORK_NETWORK_PORTAL_DETECTOR_OBSERVER_H_	6 #define ASH_COMMON_SYSTEM_CHROMEOS_NETWORK_NETWORK_PORTAL_DETECTOR_OBSERVER_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 namespace ash {	10 namespace ash {

11	11

12 class NetworkPortalDetectorObserver {	12 class NetworkPortalDetectorObserver {

13 public:	13 public:

14 virtual ~NetworkPortalDetectorObserver() {}	14 virtual ~NetworkPortalDetectorObserver() {}

15	15

16 // Called when captive portal is detected for a \|network\|.	16 // Called when captive portal is detected for a \|network\|.
	stevenjb 2017/02/16 23:57:48 nit: Fix comment nit: Fix comment Ryan Hansberry 2017/02/17 01:43:18 Done. Show quoted text On 2017/02/16 23:57:48, stevenjb wrote: > nit: Fix comment Done.
17 virtual void OnCaptivePortalDetected(const std::string& service_path) = 0;	17 virtual void OnCaptivePortalDetected(const std::string& guid) = 0;

18 };	18 };

19	19

20 } // namespace ash	20 } // namespace ash

21	21

22 #endif // ASH_COMMON_SYSTEM_CHROMEOS_NETWORK_NETWORK_PORTAL_DETECTOR_OBSERVER_H _	22 #endif // ASH_COMMON_SYSTEM_CHROMEOS_NETWORK_NETWORK_PORTAL_DETECTOR_OBSERVER_H _

OLD	NEW