Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2698473006: Set layer scroll data from PaintArtifactCompositor (Closed)

Created:
3 years, 10 months ago by pdr.
Modified:
3 years, 10 months ago
Reviewers:
ajuma, wkorman
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set layer scroll data from PaintArtifactCompositor This is a followup to [1] and begins setting scroll data on cc::Layer from Blink's PaintArtifactCompositor. Because there's a 1:1 mapping between scroll property nodes and ScrollableAreas, a WebLayerScrollClient field has been added to the scroll property node. This field is then used in the paint artifact compositor to set cc::Layer's did scroll callback. With this patch, simple pages can be compositor wheel-scrolled on Windows. [1] https://codereview.chromium.org/2680953002 BUG=667946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2698473006 Cr-Commit-Position: refs/heads/master@{#451481} Committed: https://chromium.googlesource.com/chromium/src/+/5d0f1c5d4ef47d3438c5b51db5da4aa0b1441a5b

Patch Set 1 #

Total comments: 5

Patch Set 2 : early out per reviewer comments #

Patch Set 3 : More comments #

Messages

Total messages: 34 (19 generated)
pdr.
3 years, 10 months ago (2017-02-16 22:01:06 UTC) #8
wkorman
lgtm https://codereview.chromium.org/2698473006/diff/1/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp File third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp (right): https://codereview.chromium.org/2698473006/diff/1/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp#newcode330 third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp:330: if (transform->isScrollTranslation()) { Could return here if false, ...
3 years, 10 months ago (2017-02-16 22:36:22 UTC) #9
pdr.
https://codereview.chromium.org/2698473006/diff/1/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp File third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp (right): https://codereview.chromium.org/2698473006/diff/1/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp#newcode330 third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp:330: if (transform->isScrollTranslation()) { On 2017/02/16 at 22:36:22, wkorman wrote: ...
3 years, 10 months ago (2017-02-16 23:08:27 UTC) #10
ajuma
lgtm https://codereview.chromium.org/2698473006/diff/1/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp File third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp (right): https://codereview.chromium.org/2698473006/diff/1/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp#newcode336 third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp:336: if (compositorScrollNode.owning_layer_id == cc::Layer::INVALID_ID) { On 2017/02/16 23:08:27, ...
3 years, 10 months ago (2017-02-17 00:06:19 UTC) #11
pdr.
On 2017/02/17 at 00:06:19, ajuma wrote: > lgtm > > https://codereview.chromium.org/2698473006/diff/1/third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp > File third_party/WebKit/Source/platform/graphics/compositing/PropertyTreeManager.cpp (right): ...
3 years, 10 months ago (2017-02-17 19:27:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698473006/40001
3 years, 10 months ago (2017-02-17 19:28:16 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_tests_slimming_paint_v2/builds/2875) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 10 months ago (2017-02-17 20:34:43 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698473006/40001
3 years, 10 months ago (2017-02-17 21:27:13 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on ...
3 years, 10 months ago (2017-02-17 23:30:53 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698473006/40001
3 years, 10 months ago (2017-02-17 23:57:43 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on ...
3 years, 10 months ago (2017-02-18 02:00:26 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698473006/40001
3 years, 10 months ago (2017-02-18 02:56:52 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-18 03:20:19 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698473006/40001
3 years, 10 months ago (2017-02-18 18:30:50 UTC) #31
commit-bot: I haz the power
3 years, 10 months ago (2017-02-18 18:37:08 UTC) #34
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5d0f1c5d4ef47d3438c5b51db5da...

Powered by Google App Engine
This is Rietveld 408576698