ios/chrome/app/spotlight/BUILD.gn - Issue 2698473004: Split FaviconService and FaviconServiceImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/app/spotlight/BUILD.gn

Issue 2698473004: Split FaviconService and FaviconServiceImpl. (Closed)

Patch Set: Revert requiring non-null service for FaviconHandler. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/app/spotlight/BUILD.gn

diff --git a/ios/chrome/app/spotlight/BUILD.gn b/ios/chrome/app/spotlight/BUILD.gn

index b872afa0e1a8761fcaa71db68d40fbbdeae98452..f8505c4108c0edc7e8d3633a8bde5fbb82d3334a 100644

--- a/ios/chrome/app/spotlight/BUILD.gn

+++ b/ios/chrome/app/spotlight/BUILD.gn

@@ -60,6 +60,7 @@ source_set("unit_tests") {

"//components/bookmarks/browser",

"//components/bookmarks/test",

"//components/favicon/core",

+ "//components/favicon/core/test:test_support",

"//components/favicon_base",

"//ios/chrome/browser/bookmarks",

"//ios/public/provider/chrome/browser",