ios/chrome/app/spotlight/BUILD.gn - Issue 2698473004: Split FaviconService and FaviconServiceImpl.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/app/spotlight/BUILD.gn

Issue 2698473004: Split FaviconService and FaviconServiceImpl. (Closed)

Patch Set: Revert requiring non-null service for FaviconHandler. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/favicon/core/favicon_service_impl.h ('K') | « components/ntp_tiles/icon_cacher_impl_unittest.cc ('k') | ios/chrome/app/spotlight/spotlight_manager_unittest.mm » ('j') | ios/chrome/app/spotlight/spotlight_manager_unittest.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 source_set("spotlight") {	5 source_set("spotlight") {

6 sources = [	6 sources = [

7 "actions_spotlight_manager.h",	7 "actions_spotlight_manager.h",

8 "actions_spotlight_manager.mm",	8 "actions_spotlight_manager.mm",

9 "base_spotlight_manager.h",	9 "base_spotlight_manager.h",

10 "base_spotlight_manager.mm",	10 "base_spotlight_manager.mm",

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
53 testonly = true	53 testonly = true

54 sources = [	54 sources = [

55 "spotlight_manager_unittest.mm",	55 "spotlight_manager_unittest.mm",

56 ]	56 ]

57 deps = [	57 deps = [

58 ":spotlight",	58 ":spotlight",

59 "//base",	59 "//base",

60 "//components/bookmarks/browser",	60 "//components/bookmarks/browser",

61 "//components/bookmarks/test",	61 "//components/bookmarks/test",

62 "//components/favicon/core",	62 "//components/favicon/core",

	63 "//components/favicon/core/test:test_support",

63 "//components/favicon_base",	64 "//components/favicon_base",

64 "//ios/chrome/browser/bookmarks",	65 "//ios/chrome/browser/bookmarks",

65 "//ios/public/provider/chrome/browser",	66 "//ios/public/provider/chrome/browser",

66 "//ios/public/provider/chrome/browser/spotlight",	67 "//ios/public/provider/chrome/browser/spotlight",

67 "//net",	68 "//net",

68 "//testing/gtest",	69 "//testing/gtest",

69 ]	70 ]

70 libs = [ "CoreSpotlight.framework" ]	71 libs = [ "CoreSpotlight.framework" ]

71 }	72 }

OLD	NEW