Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2698443004: Hook VideoPersister.stopPersist() when onResume is received. (Closed)

Created:
3 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 10 months ago
Reviewers:
Bernhard Bauer
CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hook VideoPersister.stopPersist() when onResume is received. BUG=690006 R=bauerb@chromium.org Review-Url: https://codereview.chromium.org/2698443004 Cr-Commit-Position: refs/heads/master@{#450818} Committed: https://chromium.googlesource.com/chromium/src/+/8201abf336e367cdebf171d35332180ec59bcbac

Patch Set 1 #

Patch Set 2 : rebase on tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/media/VideoPersister.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
mlamouri (slow - plz ping)
PTAL :)
3 years, 10 months ago (2017-02-14 18:48:45 UTC) #1
PEConn
On 2017/02/14 18:48:45, mlamouri wrote: > PTAL :) When would this happen? When a persisted ...
3 years, 10 months ago (2017-02-15 11:05:31 UTC) #6
mlamouri (slow - plz ping)
On 2017/02/15 at 11:05:31, peconn wrote: > On 2017/02/14 18:48:45, mlamouri wrote: > > PTAL ...
3 years, 10 months ago (2017-02-15 11:43:13 UTC) #7
mlamouri (slow - plz ping)
Rebased on tot. Should be green now. bauerb, PTAL :)
3 years, 10 months ago (2017-02-15 11:51:23 UTC) #10
Bernhard Bauer
lgtm
3 years, 10 months ago (2017-02-15 12:00:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698443004/20001
3 years, 10 months ago (2017-02-15 21:01:36 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 22:44:04 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8201abf336e367cdebf171d35332...

Powered by Google App Engine
This is Rietveld 408576698