Web MIDI: implement sending for dynamic manager instantiation on Windows

Web MIDI: implement sending for dynamic manager instantiation on Windows

This patch makes output ports work perfectly.

BUG=497573, 617086, 672793
Review-Url: https://codereview.chromium.org/2698413003
Cr-Commit-Position: refs/heads/master@{#453866}
Committed: https://chromium.googlesource.com/chromium/src/+/eaeaadec00a39dcd1c725fc1e5ce1fda7cccd185

[Takashi Toyoshima, 2017-02-27 07:38:36]

Description was changed from

==========
Web MIDI: implement sending for dynamic manager instantiation on Windows

This patch makes output ports work perfectly.

BUG=497573, 617086, 672793
==========

to

==========
Web MIDI: implement sending for dynamic manager instantiation on Windows

This patch makes output ports work perfectly.

BUG=497573, 617086, 672793
==========

[Takashi Toyoshima, 2017-02-27 07:38:36]

toyoshim@chromium.org changed reviewers:
+ yhirano@chromium.org

[Takashi Toyoshima, 2017-02-27 07:38:48]

ptal

[yhirano, 2017-03-01 01:48:50]

lgtm

https://codereview.chromium.org/2698413003/diff/40001/media/midi/dynamically_...
File media/midi/dynamically_initialized_midi_manager_win.cc (right):

https://codereview.chromium.org/2698413003/diff/40001/media/midi/dynamically_...
media/midi/dynamically_initialized_midi_manager_win.cc:447: DWORD message = 0;
[optional] I would prefer defining |message| as a uint32_t, and cast it when
passing it to midiOutShortMsg.

https://codereview.chromium.org/2698413003/diff/80001/media/midi/dynamically_...
File media/midi/dynamically_initialized_midi_manager_win.cc (right):

https://codereview.chromium.org/2698413003/diff/80001/media/midi/dynamically_...
media/midi/dynamically_initialized_midi_manager_win.cc:468: // MIDIHDR will be
released on MOM_DONE.
+2 indent

[Takashi Toyoshima, 2017-03-01 03:38:02]

https://codereview.chromium.org/2698413003/diff/40001/media/midi/dynamically_...
File media/midi/dynamically_initialized_midi_manager_win.cc (right):

https://codereview.chromium.org/2698413003/diff/40001/media/midi/dynamically_...
media/midi/dynamically_initialized_midi_manager_win.cc:447: DWORD message = 0;
changed to uint32_t.
cast is not needed to pass it to the Win32 API because DWORD is uint32_t (though
I'm not sure win clang bot agreed. let me try).

https://codereview.chromium.org/2698413003/diff/80001/media/midi/dynamically_...
File media/midi/dynamically_initialized_midi_manager_win.cc (right):

https://codereview.chromium.org/2698413003/diff/80001/media/midi/dynamically_...
media/midi/dynamically_initialized_midi_manager_win.cc:468: // MIDIHDR will be
released on MOM_DONE.
ah, "cl format" changed this indent. I will use {} for this if-else.

[Takashi Toyoshima, 2017-03-01 03:39:05]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 03:39:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 05:32:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 05:32:49]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2017-03-01 06:32:22]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2017-03-01 06:32:23]

The patchset sent to the CQ was uploaded after l-g-t-m from yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2698413003/#ps100001
(title: "review #4")

[commit-bot: I haz the power, 2017-03-01 06:32:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 06:36:48]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488349942735290,
"parent_rev": "8558df98469ef25bcd685bd9f9b0dc080ad2dc5b", "commit_rev":
"eaeaadec00a39dcd1c725fc1e5ce1fda7cccd185"}

[commit-bot: I haz the power, 2017-03-01 06:37:31]

Description was changed from

==========
Web MIDI: implement sending for dynamic manager instantiation on Windows

This patch makes output ports work perfectly.

BUG=497573, 617086, 672793
==========

to

==========
Web MIDI: implement sending for dynamic manager instantiation on Windows

This patch makes output ports work perfectly.

BUG=497573, 617086, 672793

Review-Url: https://codereview.chromium.org/2698413003
Cr-Commit-Position: refs/heads/master@{#453866}
Committed:
https://chromium.googlesource.com/chromium/src/+/eaeaadec00a39dcd1c725fc1e5ce...
==========

[commit-bot: I haz the power, 2017-03-01 06:37:32]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/eaeaadec00a39dcd1c725fc1e5ce...