Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2698363002: Adjust a test expectation in the stack sampler unit test. (Closed)

Created:
3 years, 10 months ago by Avi (use Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
Mike Wittman
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust a test expectation in the stack sampler unit test. When unloading a library, it's a race, but one of the possible results was mis-tested. Fix the test. BUG=531673 TEST=nothing manual; everything should stay green. Review-Url: https://codereview.chromium.org/2698363002 Cr-Commit-Position: refs/heads/master@{#451147} Committed: https://chromium.googlesource.com/chromium/src/+/c4dbfa9fc24da8f0be72945b3e4d5e6ad694c9bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/profiler/stack_sampling_profiler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Avi (use Gerrit)
3 years, 10 months ago (2017-02-16 23:16:43 UTC) #4
Mike Wittman
lgtm
3 years, 10 months ago (2017-02-16 23:17:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698363002/1
3 years, 10 months ago (2017-02-16 23:21:47 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 00:10:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c4dbfa9fc24da8f0be72945b3e4d...

Powered by Google App Engine
This is Rietveld 408576698