Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2698333003: S390: Minor fix to add missing argument (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Minor fix to add missing argument R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2698333003 Cr-Commit-Position: refs/heads/master@{#43287} Committed: https://chromium.googlesource.com/v8/v8/+/b41ed49041e416ee91ac8b23b901db350a231dad

Patch Set 1 #

Patch Set 2 : USE() to silience C++ compiler warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-02-17 15:40:17 UTC) #1
JoranSiu
On 2017/02/17 15:40:17, JaideepBajwa wrote: > ptal lgtm
3 years, 10 months ago (2017-02-17 15:42:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698333003/20001
3 years, 10 months ago (2017-02-17 15:52:11 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 16:19:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/b41ed49041e416ee91ac8b23b901db350a2...

Powered by Google App Engine
This is Rietveld 408576698