Fix caret paint invalidation when moving between blocks

Fix caret paint invalidation when moving between blocks

Previously when caret is moved between blocks, the code only worked
if the source block was visited before the target block during paint
invalidation. If the target block was visited earlier (depending on
the dom order), CaretDisplayItemClient::m_visualRect would be set to
the visual rect of the new caret, then when the source block was
visited, we invalidated the old caret at the location of the new
caret.

Add CaretDisplayItemClient::m_previousVisualRect,
and set it to m_visualRect when m_previousBlock is set to
m_layoutBlock. When m_previousBlock is visited, invalidate
m_previousVisualRect.

Move Source/core/paint/BlockPaintInvalidatorTest.cpp to
Source/core/editing/CaretDisplayItemClientTest.cpp to be closer
to the tested code.

BUG=690352
TEST=CaretDisplayItemClientTest.CaretMovesBetweenBlocks
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2698313003
Cr-Commit-Position: refs/heads/master@{#451440}
Committed: https://chromium.googlesource.com/chromium/src/+/942dfae2326142b0af47b32c407b70c2e13e86fc

[Xianzhu, 2017-02-17 07:40:22]

Description was changed from

==========
Fix caret paint invalidation when moving between blocks

Previously when caret is moved between blocks, the code only worked
if the source block was visited before the target block during paint
invalidation. If the target block was visited earlier (depending on
the dom order), CaretDisplayItemClient::m_visualRect would be set to
the visual rect of the new caret, then when the source block was
visited, we invalidated the old caret at the location of the new
caret.

Add CaretDisplayItemClient::m_visualRectWhenCaretWasInPreviousBlock,
and set it to m_visualRect when m_previousBlock is set to
m_layoutBlock. When m_previousBlock is visited, invalidate
m_visualRectWhenCaretWasInPreviousBlock.

BUG=690352
TEST=BoxPaintInvalidatorTest.CaretMovesBetweenBlocks
==========

to

==========
Fix caret paint invalidation when moving between blocks

Previously when caret is moved between blocks, the code only worked
if the source block was visited before the target block during paint
invalidation. If the target block was visited earlier (depending on
the dom order), CaretDisplayItemClient::m_visualRect would be set to
the visual rect of the new caret, then when the source block was
visited, we invalidated the old caret at the location of the new
caret.

Add CaretDisplayItemClient::m_visualRectWhenCaretWasInPreviousBlock,
and set it to m_visualRect when m_previousBlock is set to
m_layoutBlock. When m_previousBlock is visited, invalidate
m_visualRectWhenCaretWasInPreviousBlock.

BUG=690352
TEST=BoxPaintInvalidatorTest.CaretMovesBetweenBlocks
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-02-17 07:40:23]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 07:40:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 08:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 08:40:33]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2017-02-17 17:40:28]

Description was changed from

==========
Fix caret paint invalidation when moving between blocks

Previously when caret is moved between blocks, the code only worked
if the source block was visited before the target block during paint
invalidation. If the target block was visited earlier (depending on
the dom order), CaretDisplayItemClient::m_visualRect would be set to
the visual rect of the new caret, then when the source block was
visited, we invalidated the old caret at the location of the new
caret.

Add CaretDisplayItemClient::m_visualRectWhenCaretWasInPreviousBlock,
and set it to m_visualRect when m_previousBlock is set to
m_layoutBlock. When m_previousBlock is visited, invalidate
m_visualRectWhenCaretWasInPreviousBlock.

BUG=690352
TEST=BoxPaintInvalidatorTest.CaretMovesBetweenBlocks
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix caret paint invalidation when moving between blocks

Previously when caret is moved between blocks, the code only worked
if the source block was visited before the target block during paint
invalidation. If the target block was visited earlier (depending on
the dom order), CaretDisplayItemClient::m_visualRect would be set to
the visual rect of the new caret, then when the source block was
visited, we invalidated the old caret at the location of the new
caret.

Add CaretDisplayItemClient::m_previousVisualRect,
and set it to m_visualRect when m_previousBlock is set to
m_layoutBlock. When m_previousBlock is visited, invalidate
m_previousVisualRect.

Move Source/core/paint/BlockPaintInvalidatorTest.cpp to
Source/core/editing/CaretDisplayItemClientTest.cpp to be closer
to the tested code.

BUG=690352
TEST=CaretDisplayItemClientTest.CaretMovesBetweenBlocks
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-02-17 17:54:34]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 17:55:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2017-02-17 18:02:57]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[Xianzhu, 2017-02-17 18:02:58]

https://codereview.chromium.org/2698313003/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/4776765-expected.txt
(right):

https://codereview.chromium.org/2698313003/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/4776765-expected.txt:35:
},
This is because now we invalidate caret display item client in both
invalidatePaintInCurrentLayoutBlock and invalidatePaintInPreviousLayoutBlock.
See comment in CaretDisplayItemClient.cpp.

https://codereview.chromium.org/2698313003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp (left):

https://codereview.chromium.org/2698313003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp:176: if
(!m_layoutBlock) {
The "will be done" assumption was incorrect because m_layoutBlock may be visited
earlier. m_layoutBlock and m_previousLayoutBlock may also in different painting
layer, so line 177 should be executed for both.

https://codereview.chromium.org/2698313003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp:180:
m_visualRect = LayoutRect();
This is moved into updateStyleAndLayoutIfNeeded(). The previous code may cause
unnecessary paint invalidation of the "previous visual rect in previous block"
on the current block, because m_visualRect may be the visual rect in previous
block.

[commit-bot: I haz the power, 2017-02-17 20:06:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 20:06:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[chrishtr, 2017-02-17 21:10:51]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-02-17 21:10:52]

lgtm

[commit-bot: I haz the power, 2017-02-17 21:12:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 23:14:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 23:14:41]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Xianzhu, 2017-02-18 07:30:14]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-02-18 07:30:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 07:34:10]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487403014235410,
"parent_rev": "ba7ad64c7261ca0facc8f5e9eb1765a006f457b0", "commit_rev":
"942dfae2326142b0af47b32c407b70c2e13e86fc"}

[commit-bot: I haz the power, 2017-02-18 07:34:46]

Description was changed from

==========
Fix caret paint invalidation when moving between blocks

Previously when caret is moved between blocks, the code only worked
if the source block was visited before the target block during paint
invalidation. If the target block was visited earlier (depending on
the dom order), CaretDisplayItemClient::m_visualRect would be set to
the visual rect of the new caret, then when the source block was
visited, we invalidated the old caret at the location of the new
caret.

Add CaretDisplayItemClient::m_previousVisualRect,
and set it to m_visualRect when m_previousBlock is set to
m_layoutBlock. When m_previousBlock is visited, invalidate
m_previousVisualRect.

Move Source/core/paint/BlockPaintInvalidatorTest.cpp to
Source/core/editing/CaretDisplayItemClientTest.cpp to be closer
to the tested code.

BUG=690352
TEST=CaretDisplayItemClientTest.CaretMovesBetweenBlocks
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix caret paint invalidation when moving between blocks

Previously when caret is moved between blocks, the code only worked
if the source block was visited before the target block during paint
invalidation. If the target block was visited earlier (depending on
the dom order), CaretDisplayItemClient::m_visualRect would be set to
the visual rect of the new caret, then when the source block was
visited, we invalidated the old caret at the location of the new
caret.

Add CaretDisplayItemClient::m_previousVisualRect,
and set it to m_visualRect when m_previousBlock is set to
m_layoutBlock. When m_previousBlock is visited, invalidate
m_previousVisualRect.

Move Source/core/paint/BlockPaintInvalidatorTest.cpp to
Source/core/editing/CaretDisplayItemClientTest.cpp to be closer
to the tested code.

BUG=690352
TEST=CaretDisplayItemClientTest.CaretMovesBetweenBlocks
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2698313003
Cr-Commit-Position: refs/heads/master@{#451440}
Committed:
https://chromium.googlesource.com/chromium/src/+/942dfae2326142b0af47b32c407b...
==========

[commit-bot: I haz the power, 2017-02-18 07:34:47]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/942dfae2326142b0af47b32c407b...