Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2698293002: Mark text-font-height-mismatch.html as NeedsRebaseline (Closed)

Created:
3 years, 10 months ago by bungeman-chromium
Modified:
3 years, 10 months ago
Reviewers:
drott
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark text-font-height-mismatch.html as NeedsRebaseline A fix in Skia when calculating x-height on Mac causes this image to change. Now that the Skia change has landed in Chromium, rebaseline the image. TBR=drott@chromium.org Changes one NeedsManualRebaseline to NeedsRebaseline. BUG=skia:6203 Review-Url: https://codereview.chromium.org/2698293002 Cr-Commit-Position: refs/heads/master@{#451128} Committed: https://chromium.googlesource.com/chromium/src/+/af955ba9399c044e55cb1c5a5543471e28c6c106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (5 generated)
bungeman-chromium
3 years, 10 months ago (2017-02-16 20:25:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698293002/1
3 years, 10 months ago (2017-02-16 20:26:14 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 22:43:49 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/af955ba9399c044e55cb1c5a5543...

Powered by Google App Engine
This is Rietveld 408576698