Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2698273004:
Add workaround for GPU detection inside a Citrix remote session. (Closed)
|
Created:
3 years, 10 months ago by Georges Khalil Modified:
3 years, 9 months ago CC:
blumberg, chromium-reviews, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd workaround for GPU detection inside a Citrix remote session.
This CL extends the workaround to Citrix sessions (previously only pure RDP sessions were considered).
Note: I've tested this manually in our lab environment.
BUG=681063
TBR=zmo@chromium.org
Review-Url: https://codereview.chromium.org/2698273004
Cr-Commit-Position: refs/heads/master@{#452538}
Committed: https://chromium.googlesource.com/chromium/src/+/e7b6ddf8b2940d17dc8dd0feaffce5b33ecee785
Patch Set 1 #
Messages
Total messages: 16 (9 generated)
Description was changed from ========== Add workaround for GPU detection inside a Citrix remote session. BUG= ========== to ========== Add workaround for GPU detection inside a Citrix remote session. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add workaround for GPU detection inside a Citrix remote session. BUG= ========== to ========== Add workaround for GPU detection inside a Citrix remote session. This CL extends the workaround to Citrix sessions (previously only pure RDP sessions were considered). BUG=681063 ==========
georgesak@chromium.org changed reviewers: + zmo@chromium.org
zmo@, PTAL.
Description was changed from ========== Add workaround for GPU detection inside a Citrix remote session. This CL extends the workaround to Citrix sessions (previously only pure RDP sessions were considered). BUG=681063 ========== to ========== Add workaround for GPU detection inside a Citrix remote session. This CL extends the workaround to Citrix sessions (previously only pure RDP sessions were considered). Note: I've tested this manually in our lab environment. BUG=681063 ==========
On 2017/02/16 at 19:00:37, georgesak wrote: > zmo@, PTAL. LGTM based on our discussion, will see how this fits in the refactor I'm doing.
On 2017/02/16 23:28:41, Corentin Wallez wrote: > On 2017/02/16 at 19:00:37, georgesak wrote: > > zmo@, PTAL. > > LGTM based on our discussion, will see how this fits in the refactor I'm doing. zmo@, friendly ping.
On 2017/02/21 at 20:03:26, georgesak wrote: > On 2017/02/16 23:28:41, Corentin Wallez wrote: > > On 2017/02/16 at 19:00:37, georgesak wrote: > > > zmo@, PTAL. > > > > LGTM based on our discussion, will see how this fits in the refactor I'm doing. > > zmo@, friendly ping. This CL has very little risk, let's land it TBR.
Description was changed from ========== Add workaround for GPU detection inside a Citrix remote session. This CL extends the workaround to Citrix sessions (previously only pure RDP sessions were considered). Note: I've tested this manually in our lab environment. BUG=681063 ========== to ========== Add workaround for GPU detection inside a Citrix remote session. This CL extends the workaround to Citrix sessions (previously only pure RDP sessions were considered). Note: I've tested this manually in our lab environment. BUG=681063 TBR=zmo@chromium.org ==========
cwallez@chromium.org changed reviewers: + cwallez@chromium.org
The CQ bit was checked by cwallez@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487868128488480, "parent_rev":
"599f8a6501faefe8a8f254ea364191e2b453ec25", "commit_rev":
"e7b6ddf8b2940d17dc8dd0feaffce5b33ecee785"}
Message was sent while issue was closed.
Description was changed from ========== Add workaround for GPU detection inside a Citrix remote session. This CL extends the workaround to Citrix sessions (previously only pure RDP sessions were considered). Note: I've tested this manually in our lab environment. BUG=681063 TBR=zmo@chromium.org ========== to ========== Add workaround for GPU detection inside a Citrix remote session. This CL extends the workaround to Citrix sessions (previously only pure RDP sessions were considered). Note: I've tested this manually in our lab environment. BUG=681063 TBR=zmo@chromium.org Review-Url: https://codereview.chromium.org/2698273004 Cr-Commit-Position: refs/heads/master@{#452538} Committed: https://chromium.googlesource.com/chromium/src/+/e7b6ddf8b2940d17dc8dd0feaffc... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e7b6ddf8b2940d17dc8dd0feaffc...
Message was sent while issue was closed.
On 2017/02/23 17:38:12, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/e7b6ddf8b2940d17dc8dd0feaffc... lgtm after the fact. Sorry about the delay, I just processed my emails to this one. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
