Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 2698243002: Add out-of-flow objects under the inline in a continuation chain, when possible. (Closed)

Created:
3 years, 10 months ago by mstensho (USE GERRIT)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add out-of-flow objects under the inline in a continuation chain, when possible. The same goes for floating objects. Only when a floating or out-of-flow positioned object is to be added between two block-level children should we add it to the anonymous block box holding the block-level children. If the new child is to be added before a block-level child, and this beforeChild is the first block-level child, we should rather make the new child the last child of the preceding inline, rather than the first child of the anonymous block containing block-level children. Also cleaned up and documented the code somewhat. BUG=689643 Review-Url: https://codereview.chromium.org/2698243002 Cr-Commit-Position: refs/heads/master@{#451525} Committed: https://chromium.googlesource.com/chromium/src/+/77ec19ddefb32688cd18277ed7412531b536401a

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
A third_party/WebKit/LayoutTests/fast/inline/add-abspos-before-block-inside-inline.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/inline/add-abspos-before-block-inside-inline-expected.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutInline.cpp View 1 1 chunk +14 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
mstensho (USE GERRIT)
See patch set #1 for actual changes. The rest is just cleanup.
3 years, 10 months ago (2017-02-16 12:49:08 UTC) #6
eae
LGTM
3 years, 10 months ago (2017-02-17 19:44:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698243002/20001
3 years, 10 months ago (2017-02-17 19:45:49 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/284635)
3 years, 10 months ago (2017-02-17 20:36:54 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698243002/20001
3 years, 10 months ago (2017-02-19 17:36:50 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-19 18:59:46 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/77ec19ddefb32688cd18277ed741...

Powered by Google App Engine
This is Rietveld 408576698