Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2698213004: Start removing some pre-md constants and related code. (Closed)

Created:
3 years, 10 months ago by Evan Stade
Modified:
3 years, 10 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start removing some pre-md constants and related code. BUG=693282 Review-Url: https://codereview.chromium.org/2698213004 Cr-Commit-Position: refs/heads/master@{#451780} Committed: https://chromium.googlesource.com/chromium/src/+/304ce3931f9c5c4f63a94de6047b242ae239925d

Patch Set 1 #

Patch Set 2 : format #

Total comments: 2

Patch Set 3 : rebase/fix conflict #

Patch Set 4 : actually use the constant #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -82 lines) Patch
M ash/common/system/status_area_widget_delegate.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M ash/common/system/tray/system_tray_item.h View 3 chunks +2 lines, -8 lines 0 comments Download
M ash/common/system/tray/system_tray_item.cc View 2 chunks +5 lines, -15 lines 0 comments Download
M ash/common/system/tray/tray_constants.h View 3 chunks +4 lines, -12 lines 0 comments Download
M ash/common/system/tray/tray_constants.cc View 5 chunks +3 lines, -12 lines 0 comments Download
M ash/common/system/tray/tray_details_view.h View 1 2 2 chunks +2 lines, -6 lines 0 comments Download
M ash/common/system/tray/tray_details_view.cc View 1 2 3 2 chunks +4 lines, -14 lines 0 comments Download
M ash/common/system/tray/tray_details_view_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/system/tray/tray_popup_utils.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Evan Stade
Stopped here because there are some non-trivial changes.
3 years, 10 months ago (2017-02-17 00:58:52 UTC) #3
tdanderson
LGTM with one comment https://codereview.chromium.org/2698213004/diff/20001/ash/common/system/tray/tray_details_view.cc File ash/common/system/tray/tray_details_view.cc (right): https://codereview.chromium.org/2698213004/diff/20001/ash/common/system/tray/tray_details_view.cc#newcode459 ash/common/system/tray/tray_details_view.cc:459: base::TimeDelta::FromMilliseconds(100), this, Use kTrayDetailedViewTransitionDelayMs in ...
3 years, 10 months ago (2017-02-17 21:46:11 UTC) #9
Evan Stade
https://codereview.chromium.org/2698213004/diff/20001/ash/common/system/tray/tray_details_view.cc File ash/common/system/tray/tray_details_view.cc (right): https://codereview.chromium.org/2698213004/diff/20001/ash/common/system/tray/tray_details_view.cc#newcode459 ash/common/system/tray/tray_details_view.cc:459: base::TimeDelta::FromMilliseconds(100), this, On 2017/02/17 21:46:11, tdanderson wrote: > Use ...
3 years, 10 months ago (2017-02-17 21:51:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698213004/60001
3 years, 10 months ago (2017-02-17 21:52:15 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-17 23:55:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698213004/60001
3 years, 10 months ago (2017-02-21 16:15:36 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 17:01:08 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/304ce3931f9c5c4f63a94de6047b...

Powered by Google App Engine
This is Rietveld 408576698