Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2698203004: Fixed compilation after 688009 cherry-pick (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
lpromero
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fixed compilation after 688009 cherry-pick The problem was caused by incorrect merge conflict resolution. BUG=688009 NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Eugene But (OOO till 7-30)
3 years, 10 months ago (2017-02-16 18:25:28 UTC) #2
lpromero
lgtm
3 years, 10 months ago (2017-02-16 18:28:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698203004/1
3 years, 10 months ago (2017-02-16 18:33:31 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-16 18:33:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698203004/1
3 years, 10 months ago (2017-02-16 18:37:26 UTC) #10
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 10 months ago (2017-02-16 19:03:59 UTC) #13
lpromero
3 years, 10 months ago (2017-02-17 13:48:12 UTC) #14
On 2017/02/16 19:03:59, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

This has been committed:
commit aa2485e99f2a87ab0fe88e6185960c9a153f0e4f
Author: eugenebut <eugenebut@chromium.org>
Date:   Thu Feb 16 20:01:23 2017

    Fixed compilation after 688009 cherry-pick

    The problem was caused by incorrect merge conflict resolution.

    BUG=688009
    NOTRY=true
    NOPRESUBMIT=true

    Review-Url: https://codereview.chromium.org/2698203004
    Cr-Commit-Position: refs/branch-heads/2987@{#552}
    Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

Powered by Google App Engine
This is Rietveld 408576698