DevTools: teach automapping to map complex sourcemap setups.

DevTools: teach automapping to map complex sourcemap setups.

Consider a sourcemap with inlined sources, which has one of the source
urls equals to the compiled url.

In this case, we append the ' [sm]' suffix to the source URL so that
the UISourceCode would not clash in the Workspace. (see crbug.com/562870).
This, however, kills the ability to map this file to the workspace.

This patch exploits the ability of automapping to handle query parameters.
By appending '? [sm]' instead of just ' [sm]', the automapping is able
to establish a binding based on the source size.

BUG=596422, 605548
R=dgozman

Review-Url: https://codereview.chromium.org/2698183003
Cr-Commit-Position: refs/heads/master@{#451430}
Committed: https://chromium.googlesource.com/chromium/src/+/9614d5a7ab4b1ea2de28ba38edb198c4e7e2a93e

[lushnikov, 2017-02-17 01:19:06]

please, take a look

[lushnikov, 2017-02-17 01:19:12]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-17 01:20:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 03:23:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 03:23:46]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[dgozman, 2017-02-17 21:16:07]

lgtm

[lushnikov, 2017-02-17 22:15:37]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2017-02-17 22:15:38]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2698183003/#ps20001
(title: "rebaseline")

[commit-bot: I haz the power, 2017-02-17 22:17:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 00:20:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-18 00:20:55]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[lushnikov, 2017-02-18 03:03:43]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-02-18 03:04:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lushnikov, 2017-02-18 04:36:49]

The CQ bit was unchecked by lushnikov@chromium.org

[lushnikov, 2017-02-18 04:37:11]

Description was changed from

==========
DevTools: teach automapping to map complex sourcemap setups.

Consider a sourcemap with inlined sources, which has one of the source
urls equals to the compiled url.

In this case, we append the ' [sm]' suffix to the source URL so that
the UISourceCode would not clash in the Workspace. (see crbug.com/562870).
This, however, kills the ability to map this file to the workspace.

This patch exploits the ability of automapping to handle query parameters.
By appending '? [sm]' instead of just ' [sm]', the automapping is able
to establish a binding based on the source size.

BUG=596422
R=dgozman
==========

to

==========
DevTools: teach automapping to map complex sourcemap setups.

Consider a sourcemap with inlined sources, which has one of the source
urls equals to the compiled url.

In this case, we append the ' [sm]' suffix to the source URL so that
the UISourceCode would not clash in the Workspace. (see crbug.com/562870).
This, however, kills the ability to map this file to the workspace.

This patch exploits the ability of automapping to handle query parameters.
By appending '? [sm]' instead of just ' [sm]', the automapping is able
to establish a binding based on the source size.

BUG=596422, 605548
R=dgozman
==========

[lushnikov, 2017-02-18 04:37:17]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2017-02-18 04:37:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-18 06:36:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487392637446590,
"parent_rev": "d6fa448cd41d51f3b637f5bcfa4d6aac5d13abb8", "commit_rev":
"9614d5a7ab4b1ea2de28ba38edb198c4e7e2a93e"}

[commit-bot: I haz the power, 2017-02-18 06:37:34]

Description was changed from

==========
DevTools: teach automapping to map complex sourcemap setups.

Consider a sourcemap with inlined sources, which has one of the source
urls equals to the compiled url.

In this case, we append the ' [sm]' suffix to the source URL so that
the UISourceCode would not clash in the Workspace. (see crbug.com/562870).
This, however, kills the ability to map this file to the workspace.

This patch exploits the ability of automapping to handle query parameters.
By appending '? [sm]' instead of just ' [sm]', the automapping is able
to establish a binding based on the source size.

BUG=596422, 605548
R=dgozman
==========

to

==========
DevTools: teach automapping to map complex sourcemap setups.

Consider a sourcemap with inlined sources, which has one of the source
urls equals to the compiled url.

In this case, we append the ' [sm]' suffix to the source URL so that
the UISourceCode would not clash in the Workspace. (see crbug.com/562870).
This, however, kills the ability to map this file to the workspace.

This patch exploits the ability of automapping to handle query parameters.
By appending '? [sm]' instead of just ' [sm]', the automapping is able
to establish a binding based on the source size.

BUG=596422, 605548
R=dgozman

Review-Url: https://codereview.chromium.org/2698183003
Cr-Commit-Position: refs/heads/master@{#451430}
Committed:
https://chromium.googlesource.com/chromium/src/+/9614d5a7ab4b1ea2de28ba38edb1...
==========

[commit-bot: I haz the power, 2017-02-18 06:37:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9614d5a7ab4b1ea2de28ba38edb1...