Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2698163002:
Update 'Saved data' description for better translation (Closed)
|
Created:
3 years, 10 months ago by megjablon Modified:
3 years, 10 months ago Reviewers:
cpu_(ooo_6.6-7.5) CC:
chromium-reviews, srahim+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpdate 'Saved data' description for better translation
BUG=692877
Review-Url: https://codereview.chromium.org/2698163002
Cr-Commit-Position: refs/heads/master@{#451377}
Committed: https://chromium.googlesource.com/chromium/src/+/54c8e6053868a1f525bf892532f8ccd64b8c1fe9
Patch Set 1 #Patch Set 2 : Switched to suggestion #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by megjablon@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
megjablon@chromium.org changed reviewers: + grt@chromium.org
PTAL, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Update 'Saved data' description for better translation BUG=692877 ========== to ========== Update 'Saved data' description for better translation BUG=692877 ==========
megjablon@chromium.org changed reviewers: - grt@chromium.org
megjablon@chromium.org changed reviewers: + cpu@chromium.org
On 2017/02/17 00:23:58, megjablon wrote: I recommend using the following desc: The text of the infobar notifying the user that mobile data usage was reduced by showing a preview version of the web page instead of the full page
The CQ bit was checked by megjablon@chromium.org to run a CQ dry run
On 2017/02/17 00:31:36, srahim1 wrote: > On 2017/02/17 00:23:58, megjablon wrote: > > I recommend using the following desc: > > The text of the infobar notifying the user that mobile data usage was reduced by > showing a preview version of the web page instead of the full page Done! Thanks!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
lgtm
The CQ bit was checked by megjablon@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487363324287980,
"parent_rev": "e500cbd3ba36bf3216087481790f5aece0e778a5", "commit_rev":
"54c8e6053868a1f525bf892532f8ccd64b8c1fe9"}
Message was sent while issue was closed.
Description was changed from ========== Update 'Saved data' description for better translation BUG=692877 ========== to ========== Update 'Saved data' description for better translation BUG=692877 Review-Url: https://codereview.chromium.org/2698163002 Cr-Commit-Position: refs/heads/master@{#451377} Committed: https://chromium.googlesource.com/chromium/src/+/54c8e6053868a1f525bf892532f8... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/54c8e6053868a1f525bf892532f8... |
