Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2698153003: Reduce createSameThreadTask usage in modules/ (Closed)

Created:
3 years, 10 months ago by yuryu
Modified:
3 years, 10 months ago
Reviewers:
haraken, nhiroki, tzik
CC:
chromium-reviews, awdf+watch_chromium.org, shalamov, tzik, Peter Beverloo, nhiroki, hongchan, blink-reviews, wanming.lin, Raymond Toy, kinuko+fileapi, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce createSameThreadTask usage in modules/ ExecutionContextTask is deprecated and will be replaced with WTF::Closure. This patch replaces ExecutionContextTask::postTask with WebTaskRunner::postTask in some of its occurrences. BUG=625927 Review-Url: https://codereview.chromium.org/2698153003 Cr-Commit-Position: refs/heads/master@{#451268} Committed: https://chromium.googlesource.com/chromium/src/+/9d20a4962d5ffabb59953294bb28c6c9799422a8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move a static callback to an anonymous namespace #

Messages

Total messages: 20 (11 generated)
yuryu
Hi, can you take a look?
3 years, 10 months ago (2017-02-16 15:02:11 UTC) #6
haraken
LGTM
3 years, 10 months ago (2017-02-16 15:31:46 UTC) #7
nhiroki
lgtm https://codereview.chromium.org/2698153003/diff/1/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp File third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp (right): https://codereview.chromium.org/2698153003/diff/1/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp#newcode64 third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp:64: static void runNotifyInitialAvailabilityTask( nit: Can you move this ...
3 years, 10 months ago (2017-02-17 03:47:15 UTC) #8
tzik
lgtm
3 years, 10 months ago (2017-02-17 04:34:19 UTC) #9
yuryu
https://codereview.chromium.org/2698153003/diff/1/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp File third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp (right): https://codereview.chromium.org/2698153003/diff/1/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp#newcode64 third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp:64: static void runNotifyInitialAvailabilityTask( On 2017/02/17 03:47:15, nhiroki wrote: > ...
3 years, 10 months ago (2017-02-17 05:14:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698153003/20001
3 years, 10 months ago (2017-02-17 05:16:04 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/17126)
3 years, 10 months ago (2017-02-17 07:13:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698153003/20001
3 years, 10 months ago (2017-02-17 07:32:44 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 08:27:46 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9d20a4962d5ffabb59953294bb28...

Powered by Google App Engine
This is Rietveld 408576698