[MD WebUI] Polymer-CSS-Build across all bundles.

[MD WebUI] Polymer-CSS-Build across all bundles.

This CL makes the vulcanize GN build able to process multiple bundles
when running Polymer-CSS-Build. This was causing styles to be missing
in MD History because they were not getting inlined.

BUG=691436
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2698143003
Cr-Commit-Position: refs/heads/master@{#451210}
Committed: https://chromium.googlesource.com/chromium/src/+/304a22faf3a175594c3958906eca6dd8833cb1c7

[calamity, 2017-02-16 04:27:27]

Description was changed from

==========
[MD WebUI] Polymer-CSS-Build across all bundles.

This CL makes the vulcanize GN build able to process multiple bundles
when running Polymer-CSS-Build. This was causing styles to be missing
in MD History because they were not getting inlined.

BUG=691436
==========

to

==========
[MD WebUI] Polymer-CSS-Build across all bundles.

This CL makes the vulcanize GN build able to process multiple bundles
when running Polymer-CSS-Build. This was causing styles to be missing
in MD History because they were not getting inlined.

BUG=691436
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[calamity, 2017-02-16 04:29:45]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-16 04:30:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-02-16 04:32:05]

calamity@chromium.org changed reviewers:
+ dpapad@chromium.org

[calamity, 2017-02-16 04:39:07]

$ git checkout 9b40cc378411af0dccf39b5ab74137ae8ac7ea69~ --
chrome/browser/resources/vulcanize.py

$ chrome/browser/resources/vulcanize.py

$ for x in app.crisper.js app.vulcanized.html lazy_load.crisper.js
lazy_load.vulcanized.html; do echo $x; diff
out/Default/gen/chrome/browser/resources/md_history/$x
chrome/browser/resources/md_history/$x; done
app.crisper.js
app.vulcanized.html
lazy_load.crisper.js
lazy_load.vulcanized.html

No diff. So naice.

[commit-bot: I haz the power, 2017-02-16 06:33:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 06:33:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[dpapad, 2017-02-16 17:47:08]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2017-02-16 18:58:09]

LGTM with nits.

https://codereview.chromium.org/2698143003/diff/1/chrome/browser/resources/cs...
File chrome/browser/resources/css_build_gn.py (right):

https://codereview.chromium.org/2698143003/diff/1/chrome/browser/resources/cs...
chrome/browser/resources/css_build_gn.py:2: # Copyright 2016 The Chromium
Authors. All rights reserved.
2017

https://codereview.chromium.org/2698143003/diff/1/chrome/browser/resources/cs...
chrome/browser/resources/css_build_gn.py:23:
node.RunNode([node_modules.PathToPolymerCssBuild(), '-f'] + in_paths +
Did you investigate at all whether we were missing a warning from
polymer-css-build, when it does not find a referenced style module?

We should at least add a TODO to make this more robust (either by inspecting the
output for a warning, or by modifying polymer-css-build to throw an error).

https://codereview.chromium.org/2698143003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/BUILD.gn (right):

https://codereview.chromium.org/2698143003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/BUILD.gn:37:
"lazy_load.vulcanized.unbuilt.html",
Can lazy_load.vulcanized.unbuilt.html and app.vulcanized.unbuilt.html strings be
moved into variables, so that they are not repeated across this file?

[Dan Beam, 2017-02-16 19:28:09]

lgtm this looks awesome

arguable nit: css-build vs polymer-css-build?  i guess while there's only one
"css build"-like tool in Chrome (is there?) this is OK.  but i probably would've
made it just a little more specific so others don't waste time trying to use it
on non-polymer code (which it's not useful for, as far as I know).

[calamity, 2017-02-17 00:22:44]

The CQ bit was checked by calamity@chromium.org

[calamity, 2017-02-17 00:22:45]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org,
dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2698143003/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2017-02-17 00:23:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[calamity, 2017-02-17 00:24:04]

https://codereview.chromium.org/2698143003/diff/1/chrome/browser/resources/cs...
File chrome/browser/resources/css_build_gn.py (right):

https://codereview.chromium.org/2698143003/diff/1/chrome/browser/resources/cs...
chrome/browser/resources/css_build_gn.py:2: # Copyright 2016 The Chromium
Authors. All rights reserved.
On 2017/02/16 18:58:09, dpapad wrote:
> 2017

Done.

https://codereview.chromium.org/2698143003/diff/1/chrome/browser/resources/cs...
chrome/browser/resources/css_build_gn.py:23:
node.RunNode([node_modules.PathToPolymerCssBuild(), '-f'] + in_paths +
On 2017/02/16 18:58:09, dpapad wrote:
> Did you investigate at all whether we were missing a warning from
> polymer-css-build, when it does not find a referenced style module?
> 
> We should at least add a TODO to make this more robust (either by inspecting
the
> output for a warning, or by modifying polymer-css-build to throw an error).

I'll start looking now.

https://codereview.chromium.org/2698143003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_history/BUILD.gn (right):

https://codereview.chromium.org/2698143003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_history/BUILD.gn:37:
"lazy_load.vulcanized.unbuilt.html",
On 2017/02/16 18:58:09, dpapad wrote:
> Can lazy_load.vulcanized.unbuilt.html and app.vulcanized.unbuilt.html strings
be
> moved into variables, so that they are not repeated across this file?

Done.

[commit-bot: I haz the power, 2017-02-17 02:26:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:26:55]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Dan Beam, 2017-02-17 02:49:26]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:50:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 04:34:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487299766844420,
"parent_rev": "adb217e7938f1f84c3f528bec160f9cfa35fb74d", "commit_rev":
"304a22faf3a175594c3958906eca6dd8833cb1c7"}

[commit-bot: I haz the power, 2017-02-17 04:35:19]

Description was changed from

==========
[MD WebUI] Polymer-CSS-Build across all bundles.

This CL makes the vulcanize GN build able to process multiple bundles
when running Polymer-CSS-Build. This was causing styles to be missing
in MD History because they were not getting inlined.

BUG=691436
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD WebUI] Polymer-CSS-Build across all bundles.

This CL makes the vulcanize GN build able to process multiple bundles
when running Polymer-CSS-Build. This was causing styles to be missing
in MD History because they were not getting inlined.

BUG=691436
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2698143003
Cr-Commit-Position: refs/heads/master@{#451210}
Committed:
https://chromium.googlesource.com/chromium/src/+/304a22faf3a175594c3958906eca...
==========

[commit-bot: I haz the power, 2017-02-17 04:35:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/304a22faf3a175594c3958906eca...