Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 2698123003: MD Settings: About: focus radio group after selecting item (Closed)

Created:
3 years, 10 months ago by stevenjb
Modified:
3 years, 10 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: About: focus radio group after selecting item paper-radio-group sets the focused item in _onFocus() so we need to explicitly focus the radio group after selecting the correct item. BUG=687366 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2698123003 Cr-Commit-Position: refs/heads/master@{#451131} Committed: https://chromium.googlesource.com/chromium/src/+/5b9f76d231ed64f920257d9d97a507bc9752a94a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/resources/settings/about_page/channel_switcher_dialog.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
stevenjb
3 years, 10 months ago (2017-02-16 18:20:21 UTC) #3
dpapad
lgtm
3 years, 10 months ago (2017-02-16 19:36:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698123003/1
3 years, 10 months ago (2017-02-16 19:38:46 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 22:49:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5b9f76d231ed64f920257d9d97a5...

Powered by Google App Engine
This is Rietveld 408576698