[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
Review-Url: https://codereview.chromium.org/2698093002
Cr-Commit-Position: refs/heads/master@{#453287}
Committed: https://chromium.googlesource.com/chromium/src/+/5b4b4ea958b6d5ae17420f6823a4f1ed0dc24cfb

[ymzhang1, 2017-02-15 23:55:03]

ymzhang@chromium.org changed reviewers:
+ cpu@chromium.org

[ymzhang1, 2017-02-15 23:55:04]

Hello,

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS files? Thank you very much!

[ymzhang1, 2017-02-15 23:55:06]

Hello,

We are adding COMPONENT/TEAM information into OWNERS file. Would you mind
helping us to verify the added TEAM/COMPONENT or suggest the correct
TEAM/COMPONENT in your OWNERS files? Thank you very much!

[cpu_(ooo_6.6-7.5), 2017-02-17 02:52:27]

looking. Sorry for the delay.

[cpu_(ooo_6.6-7.5), 2017-02-17 03:00:30]

cpu@chromium.org changed reviewers:
+ brettw@chromium.org, wfh@chromium.org

[cpu_(ooo_6.6-7.5), 2017-02-17 03:00:30]

Some of them look pretty wrong. I think you are running your CL generator when
the spreadsheet is very incomplete.

Added a couple of people which should help with the spreadsheet, or at least
give you a better source of information.

[cpu_(ooo_6.6-7.5), 2017-02-17 03:01:40]

in particular all the ones with 'network'.

[ymzhang1, 2017-02-17 18:08:49]

Thanks cpu@ for helping!

Yes, collected mapping information under these directories are very limited
currently. I have updated some components based on the components' description.
However, they might still look wrong. It would get better as I collected more
information of these components/directories. Thanks!

[grt (UTC plus 2), 2017-02-20 09:20:19]

grt@chromium.org changed reviewers:
+ grt@chromium.org

[grt (UTC plus 2), 2017-02-20 09:20:20]

Thanks for taking a stab at this. I've made a number of suggestions. You may
need to reach out to others to confirm.

https://codereview.chromium.org/2698093002/diff/20001/base/win/OWNERS
File base/win/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/base/win/OWNERS#newcode6
base/win/OWNERS:6: # COMPONENT: Internals>WindowsServer
Internals>PlatformIntegration

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/diagnost...
File chrome/browser/diagnostics/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/diagnost...
chrome/browser/diagnostics/OWNERS:3: # COMPONENT:
Platform>Apps>Diagnostics>Connectivity
this isn't an apps thing. check with chrisha@ to see what he thinks -- i think
he's done something in here recently.

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/first_ru...
File chrome/browser/first_run/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/first_ru...
chrome/browser/first_run/OWNERS:5: # COMPONENT: Internals>Network
UI>Browser>FirstRun

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/rlz/OWNERS
File chrome/browser/rlz/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/rlz/OWNE...
chrome/browser/rlz/OWNERS:6: # COMPONENT: Internals>Network
i'm not sure about this one. please check with rogerta

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/update_c...
File chrome/browser/update_client/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/update_c...
chrome/browser/update_client/OWNERS:6: # COMPONENT: Internals>Installer
Internals>Installer>Components, i think, but check with sorin@ or waffles@

https://codereview.chromium.org/2698093002/diff/20001/components/rlz/OWNERS
File components/rlz/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/components/rlz/OWNERS#n...
components/rlz/OWNERS:6: # TEAM: layout-dev@chromium.org
rlz has nothing to do with layout

https://codereview.chromium.org/2698093002/diff/20001/components/test/data/up...
File components/test/data/update_client/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/components/test/data/up...
components/test/data/update_client/OWNERS:7: # COMPONENT: Internals>Installer
Internals>Installer>Components here as well, i think

https://codereview.chromium.org/2698093002/diff/20001/components/update_clien...
File components/update_client/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/components/update_clien...
components/update_client/OWNERS:6: # COMPONENT: Internals>Installer
Internals>Installer>Components

https://codereview.chromium.org/2698093002/diff/20001/ios/chrome/browser/upda...
File ios/chrome/browser/update_client/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/ios/chrome/browser/upda...
ios/chrome/browser/update_client/OWNERS:6: # COMPONENT: Internals>Installer
Internals>Installer>Components

[ymzhang1, 2017-02-21 18:28:42]

ymzhang@chromium.org changed reviewers:
+ chrisha@chromium.org, rogerta@chromium.org, sorin@chromium.org,
waffles@chromium.org

[ymzhang1, 2017-02-21 18:28:44]

Hello chrisha@, rogerta@, sorin@, waffles@,

Would you mind helping us to verify component/team information in following
OWNERS files? Thank you!

chrisha@
chrome/browser/diagnostics/OWNERS

rogerta@
chrome/browser/rlz/OWNERS
components/rlz/OWNERS

sorin@, waffles@
chrome/browser/update_client/OWNERS
components/component_updater/OWNERS
components/test/data/update_client/OWNERS
ios/chrome/browser/update_client/OWNERS

https://codereview.chromium.org/2698093002/diff/20001/base/win/OWNERS
File base/win/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/base/win/OWNERS#newcode6
base/win/OWNERS:6: # COMPONENT: Internals>WindowsServer
On 2017/02/20 09:20:20, grt (UTC plus 1) wrote:
> Internals>PlatformIntegration

Done.

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/diagnost...
File chrome/browser/diagnostics/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/diagnost...
chrome/browser/diagnostics/OWNERS:3: # COMPONENT:
Platform>Apps>Diagnostics>Connectivity
On 2017/02/20 09:20:20, grt (UTC plus 1) wrote:
> this isn't an apps thing. check with chrisha@ to see what he thinks -- i think
> he's done something in here recently.

Done.

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/first_ru...
File chrome/browser/first_run/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/first_ru...
chrome/browser/first_run/OWNERS:5: # COMPONENT: Internals>Network
On 2017/02/20 09:20:20, grt (UTC plus 1) wrote:
> UI>Browser>FirstRun

Done.

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/rlz/OWNERS
File chrome/browser/rlz/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/rlz/OWNE...
chrome/browser/rlz/OWNERS:6: # COMPONENT: Internals>Network
On 2017/02/20 09:20:20, grt (UTC plus 1) wrote:
> i'm not sure about this one. please check with rogerta

Done.

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/update_c...
File chrome/browser/update_client/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/update_c...
chrome/browser/update_client/OWNERS:6: # COMPONENT: Internals>Installer
On 2017/02/20 09:20:20, grt (UTC plus 1) wrote:
> Internals>Installer>Components, i think, but check with sorin@ or waffles@

Done.

https://codereview.chromium.org/2698093002/diff/20001/components/rlz/OWNERS
File components/rlz/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/components/rlz/OWNERS#n...
components/rlz/OWNERS:6: # TEAM: layout-dev@chromium.org
On 2017/02/20 09:20:20, grt (UTC plus 1) wrote:
> rlz has nothing to do with layout

Done.

https://codereview.chromium.org/2698093002/diff/20001/components/test/data/up...
File components/test/data/update_client/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/components/test/data/up...
components/test/data/update_client/OWNERS:7: # COMPONENT: Internals>Installer
On 2017/02/20 09:20:20, grt (UTC plus 1) wrote:
> Internals>Installer>Components here as well, i think

Done.

https://codereview.chromium.org/2698093002/diff/20001/components/update_clien...
File components/update_client/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/components/update_clien...
components/update_client/OWNERS:6: # COMPONENT: Internals>Installer
On 2017/02/20 09:20:20, grt (UTC plus 1) wrote:
> Internals>Installer>Components

Done.

https://codereview.chromium.org/2698093002/diff/20001/ios/chrome/browser/upda...
File ios/chrome/browser/update_client/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/ios/chrome/browser/upda...
ios/chrome/browser/update_client/OWNERS:6: # COMPONENT: Internals>Installer
On 2017/02/20 09:20:20, grt (UTC plus 1) wrote:
> Internals>Installer>Components

Done.

[Sorin Jianu, 2017-02-21 18:40:50]

lgtm

COMPONENT: Internals>Installer>Components lgtm

[waffles, 2017-02-21 18:45:45]

lgtm

[Will Harris, 2017-02-21 18:52:25]

lgtm for sandbox/OWNERS - any way of separating sandbox/win into OS=Windows and
sandbox/linux into OS=Linux etc?

[Roger Tawa OOO till Jul 10th, 2017-02-21 19:32:04]

For RLZ, Internals>Core seems better than Internals>Network.  However,
Distributions is might be better.

cpu@ What do you think?

[grt (UTC plus 2), 2017-02-22 10:52:34]

base/win lgtm

https://codereview.chromium.org/2698093002/diff/40001/components/rlz/OWNERS
File components/rlz/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/40001/components/rlz/OWNERS#n...
components/rlz/OWNERS:5: # COMPONENT: Internals>Core
this should match the value in chrome/browser/rlz/OWNERS

[sshruthi1, 2017-02-22 18:10:35]

On 2017/02/21 18:52:25, Will Harris wrote:
> lgtm for sandbox/OWNERS - any way of separating sandbox/win into OS=Windows
and
> sandbox/linux into OS=Linux etc?

That isn't a part of the current design, but there was a comment about this
recently:
https://docs.google.com/document/d/1jty6UsFMW9-SYgpQC-ztEc3lltziOQBBArMkROCST...
Please do chime in if you feel strongly about this, and we can continue the
conversation there. Thanks!

[ymzhang1, 2017-02-22 21:36:57]

Put Internals>Core for rlz directories.

https://codereview.chromium.org/2698093002/diff/40001/components/rlz/OWNERS
File components/rlz/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/40001/components/rlz/OWNERS#n...
components/rlz/OWNERS:5: # COMPONENT: Internals>Core
On 2017/02/22 10:52:34, grt (UTC plus 1) wrote:
> this should match the value in chrome/browser/rlz/OWNERS

Thanks. I'll use Internals>Core for components/rlz/OWNERS
chrome/browser/rlz/OWNERS.

[Roger Tawa OOO till Jul 10th, 2017-02-23 13:25:01]

lgtm

[chrisha, 2017-02-24 18:40:11]

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/diagnost...
File chrome/browser/diagnostics/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/diagnost...
chrome/browser/diagnostics/OWNERS:3: # COMPONENT:
Platform>Apps>Diagnostics>Connectivity
On 2017/02/21 18:28:43, ymzhang1 wrote:
> On 2017/02/20 09:20:20, grt (UTC plus 1) wrote:
> > this isn't an apps thing. check with chrisha@ to see what he thinks -- i
think
> > he's done something in here recently.
> 
> Done.

Definitely not an apps thing. This code runs when a Chrome installation is
having trouble starting up, and it will restart in "diagnostics" mode. This
component checks some simple things (databases for corruption, missing
corrupt/files, etc).

AFAICT this is only still used on ChromeOS.

The work I did here was to remove the "conflicting modules" diagnostics
component, as the backing code was ancient and XP specific, which we no longer
support.

Maybe PlatformIntegration makes sense?

[ymzhang1, 2017-02-24 19:16:14]

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/diagnost...
File chrome/browser/diagnostics/OWNERS (right):

https://codereview.chromium.org/2698093002/diff/20001/chrome/browser/diagnost...
chrome/browser/diagnostics/OWNERS:3: # COMPONENT:
Platform>Apps>Diagnostics>Connectivity
On 2017/02/24 18:40:10, chrisha wrote:
> On 2017/02/21 18:28:43, ymzhang1 wrote:
> > On 2017/02/20 09:20:20, grt (UTC plus 1) wrote:
> > > this isn't an apps thing. check with chrisha@ to see what he thinks -- i
> think
> > > he's done something in here recently.
> > 
> > Done.
> 
> Definitely not an apps thing. This code runs when a Chrome installation is
> having trouble starting up, and it will restart in "diagnostics" mode. This
> component checks some simple things (databases for corruption, missing
> corrupt/files, etc).
> 
> AFAICT this is only still used on ChromeOS.
> 
> The work I did here was to remove the "conflicting modules" diagnostics
> component, as the backing code was ancient and XP specific, which we no longer
> support.
> 
> Maybe PlatformIntegration makes sense?

Replaced with Internals>PlatformIntegration.

[cpu_(ooo_6.6-7.5), 2017-02-25 22:10:49]

Roger. Yes I agree.

[cpu_(ooo_6.6-7.5), 2017-02-25 22:15:57]

lgtm

[ymzhang1, 2017-02-27 17:53:40]

The CQ bit was checked by ymzhang@chromium.org

[ymzhang1, 2017-02-27 17:53:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
waffles@chromium.org, grt@chromium.org, sorin@chromium.org, wfh@chromium.org,
rogerta@chromium.org
Link to the patchset: https://codereview.chromium.org/2698093002/#ps80001
(title: "update component")

[commit-bot: I haz the power, 2017-02-27 17:54:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:16:31]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488218020390840,
"parent_rev": "4710b6a7757ede0b8dd6850a09f96d876ab48236", "commit_rev":
"5b4b4ea958b6d5ae17420f6823a4f1ed0dc24cfb"}

[commit-bot: I haz the power, 2017-02-27 19:17:06]

Description was changed from

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905
==========

to

==========
[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files.

We are adding COMPONENT/TEAM information into OWNERS file. Please help us to
verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your
OWNERS files. Thanks.

Proposal to add TEAM/COMPONENT information into OWNERS files
http://bit.ly/add-team-component-proposal
Proposal about how to get suggested component for directory.
http://bit.ly/directory-mapping-proposal
TEAM-COMPONENT mapping
http://bit.ly/component-team-mapping

Additional Information:
List of components
https://bugs.chromium.org/p/chromium/adminComponents

BUG=679905

Review-Url: https://codereview.chromium.org/2698093002
Cr-Commit-Position: refs/heads/master@{#453287}
Committed:
https://chromium.googlesource.com/chromium/src/+/5b4b4ea958b6d5ae17420f6823a4...
==========

[commit-bot: I haz the power, 2017-02-27 19:17:07]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/5b4b4ea958b6d5ae17420f6823a4...