Port device_generic_sensor to be hosted in Device Service.

services/device/device_service.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/device/device_service.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/weak_ptr.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "device/battery/battery_monitor.mojom.h"
 #include "device/battery/battery_monitor_impl.h"
 #include "device/battery/battery_status_service.h"
+#include "device/generic_sensor/sensor_provider_impl.h"
 #include "device/sensors/device_sensor_host.h"
 #include "device/wake_lock/wake_lock_context_provider.h"
 #include "mojo/public/cpp/system/message_pipe.h"
 #include "services/device/fingerprint/fingerprint.h"
 #include "services/device/power_monitor/power_monitor_message_broadcaster.h"
 #include "services/device/time_zone_monitor/time_zone_monitor.h"
 #include "services/service_manager/public/cpp/connection.h"
 #include "services/service_manager/public/cpp/interface_registry.h"
 #include "services/service_manager/public/cpp/service_info.h"
 #include "ui/gfx/native_widget_types.h"
@@ skipping 60 matching lines @@
 
 bool DeviceService::OnConnect(const service_manager::ServiceInfo& remote_info,
                               service_manager::InterfaceRegistry* registry) {
   registry->AddInterface<mojom::Fingerprint>(this);
   registry->AddInterface<mojom::LightSensor>(this);
   registry->AddInterface<mojom::MotionSensor>(this);
   registry->AddInterface<mojom::OrientationSensor>(this);
   registry->AddInterface<mojom::OrientationAbsoluteSensor>(this);
   registry->AddInterface<mojom::PowerMonitor>(this);
   registry->AddInterface<mojom::ScreenOrientationListener>(this);
+  registry->AddInterface<mojom::SensorProvider>(this);

[blundell, 2017/03/27 14:56:52]

We should preserve the check about the feature being enabled, right?

[ke.he, 2017/03/28 05:41:11]

The check code is: "if (base::FeatureList::IsEnabled(features::kGenericSensor))"
The features::kGenericSensor is defined in
//content/public/common/content_features.cc.

I feel we cannot add deps from //service to //content/public/, right? But I find
there is already existed deps from //service to //content/public.(in
service/navigation).

If above deps is allowed, just need to add the
"if (base::FeatureList::IsEnabled(features::kGenericSensor))" here.
Else, my plan is to create a new file services_device_features.cc in
//service/device/public/cpp, and move the definition of features::kGenericSensor
into it. Any comments? thanks!

[blundell, 2017/03/28 07:03:52]

Ah, great point! You are correct that a dep from //services/foo to //content is
in general no good (//services/navigation is essentially a sketch of what a
navigation service could look like). Your plan to do the move sounds perfect.

   registry->AddInterface<mojom::TimeZoneMonitor>(this);
   registry->AddInterface<mojom::WakeLockContextProvider>(this);
 
 #if defined(OS_ANDROID)
   registry->AddInterface(
       GetJavaInterfaceProvider()->CreateInterfaceFactory<BatteryMonitor>());
   registry->AddInterface(
       GetJavaInterfaceProvider()
           ->CreateInterfaceFactory<mojom::VibrationManager>());
 #else
@@ skipping 101 matching lines @@
 #if defined(OS_ANDROID)
   if (io_task_runner_) {
     io_task_runner_->PostTask(
         FROM_HERE, base::Bind(&ScreenOrientationListenerAndroid::Create,
                               base::Passed(&request)));
   }
 #endif
 }
 
 void DeviceService::Create(const service_manager::Identity& remote_identity,
+                           mojom::SensorProviderRequest request) {
+  if (io_task_runner_) {
+    io_task_runner_->PostTask(
+        FROM_HERE, base::Bind(&device::SensorProviderImpl::Create,
+                              file_task_runner_, base::Passed(&request)));
+  }
+}
+
+void DeviceService::Create(const service_manager::Identity& remote_identity,
                            mojom::TimeZoneMonitorRequest request) {
   if (!time_zone_monitor_)
     time_zone_monitor_ = TimeZoneMonitor::Create(file_task_runner_);
   time_zone_monitor_->Bind(std::move(request));
 }
 
 void DeviceService::Create(const service_manager::Identity& remote_identity,
                            mojom::WakeLockContextProviderRequest request) {
   WakeLockContextProvider::Create(std::move(request), file_task_runner_,
                                   wake_lock_context_callback_);
@@ skipping 10 matching lines @@
     java_interface_provider_.Bind(std::move(provider));
 
     java_interface_provider_initialized_ = true;
   }
 
   return &java_interface_provider_;
 }
 #endif
 
 }  // namespace device