Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2698083004:
Fix a bug introduced in a refactor to the ELFSymbolizer. (Closed)
DescriptionFix a bug introduced in a refactor to the ELFSymbolizer.
BUG=chromium:677302
Review-Url: https://codereview.chromium.org/2698083004
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0aecec904fe463d9ea5e3f5e30692bab81f3fe80
Patch Set 1 #
Messages
Total messages: 33 (16 generated)
erikchen@chromium.org changed reviewers: + ssid@chromium.org
ssid: Please review.
ssid@chromium.org changed reviewers: + dskiba@google.com
lgtm
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-catapult-committers". Note that this has nothing to do with OWNERS files.
dskiba@chromium.org changed reviewers: + dskiba@chromium.org
LGTM
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-catapult-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-catapult-committers". Note that this has nothing to do with OWNERS files.
ssid@chromium.org changed reviewers: + nednguyen@google.com
You need owner approval. +Ned
On 2017/02/17 01:41:24, ssid wrote: > You need owner approval. +Ned Or I guess there is different "committer" group for catapult?
On 2017/02/17 01:42:44, ssid wrote: > On 2017/02/17 01:41:24, ssid wrote: > > You need owner approval. +Ned > > Or I guess there is different "committer" group for catapult? third_party/catapult/tracing/OWNERS """ 19 # Tracing, in general, doesn't require an owners stamp to commit. If you 20 # don't think the complexity requires the review of the above you can use 21 # any tracing committer. 22 * """
On 2017/02/17 01:45:58, erikchen wrote: > On 2017/02/17 01:42:44, ssid wrote: > > On 2017/02/17 01:41:24, ssid wrote: > > > You need owner approval. +Ned > > > > Or I guess there is different "committer" group for catapult? > third_party/catapult/tracing/OWNERS > """ > 19 # Tracing, in general, doesn't require an owners stamp to commit. If you > 20 # don't think the complexity requires the review of the above you can use > 21 # any tracing committer. > 22 * > """ They need catapult project contributor owner stamp LGTM
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)
Description was changed from ========== Fix a bug introduced in a refactor to the ELFSymbolizer. BUG=catapult:# ========== to ========== Fix a bug introduced in a refactor to the ELFSymbolizer. BUG=chromium:677302 ==========
The CQ bit was checked by ssid@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487350665593600, "parent_rev":
"52aeaa8d0566087caba647e58a34032fe2001908", "commit_rev":
"0aecec904fe463d9ea5e3f5e30692bab81f3fe80"}
Message was sent while issue was closed.
Description was changed from ========== Fix a bug introduced in a refactor to the ELFSymbolizer. BUG=chromium:677302 ========== to ========== Fix a bug introduced in a refactor to the ELFSymbolizer. BUG=chromium:677302 Review-Url: https://codereview.chromium.org/2698083004 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapu... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapu... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
