Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2698043003: Use MemoryCoordinatorClientRegistry in BlinkPlatformImpl::requestPurgeMemory() (Closed)

Created:
3 years, 10 months ago by bashi
Modified:
3 years, 10 months ago
Reviewers:
kinuko
CC:
chromium-reviews, jam, darin-cc_chromium.org, mlamouri+watch-content_chromium.org, manoranjanr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use MemoryCoordinatorClientRegistry in BlinkPlatformImpl::requestPurgeMemory() ChildMemoryCoordinator isn't always avaiable. Use MemoryCoordinatorClientRegistry instead (which exists always). NOTRY=true NOPRESUBMIT=true BUG=692509 TBR=tasak@google.com,haraken@chromium.org Review-Url: https://codereview.chromium.org/2698043003 Cr-Commit-Position: refs/heads/master@{#450873} Committed: https://chromium.googlesource.com/chromium/src/+/dbaff8bba8c6269cf2f5491dc86157266a525d3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M content/public/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 3 chunks +1 line, -5 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
bashi
kinuko@: PTAL? This is somewhat urgent...
3 years, 10 months ago (2017-02-16 03:10:26 UTC) #5
kinuko
lgtm
3 years, 10 months ago (2017-02-16 03:35:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698043003/1
3 years, 10 months ago (2017-02-16 03:57:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698043003/1
3 years, 10 months ago (2017-02-16 04:29:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2698043003/1
3 years, 10 months ago (2017-02-16 05:15:35 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 05:18:14 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dbaff8bba8c6269cf2f5491dc861...

Powered by Google App Engine
This is Rietveld 408576698