Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2698013004:
Revert 3c7af99, but keep only IsReservedCommandOrKey change (Closed)
DescriptionRevert 3c7af99, but keep only IsReservedCommandOrKey change
Change
https://chromium.googlesource.com/chromium/src/+/3c7af99a93f4b4837b2fbee5cb66697f66ccf241/
impacts both keyboard shortcut reservation and enable / disable of the commands,
while the later one is not expected. So this change partially reverts the
original change.
The intent to implement is https://goo.gl/4tJ32G, which expects to deliver
browser keyboard shortcuts to the web pages.
BUG=680809
Review-Url: https://codereview.chromium.org/2698013004
Cr-Commit-Position: refs/heads/master@{#450894}
Committed: https://chromium.googlesource.com/chromium/src/+/13207802645e9185311993151707c56d28787ff7
Patch Set 1 #
Total comments: 2
Patch Set 2 : Resolve review comments #
Messages
Total messages: 26 (18 generated)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Revert 3c7af99a93f4b4837b2fbee5cb66697f66ccf241, but keep only IsReservedCommandOrKey change Change 3c7af99a93f4b4837b2fbee5cb66697f66ccf241 impacts both keyboard shortcut reservation and enable / disable of the commands, while the later one is not expected. So this change partially reverts the original change. The intent to implement is https://goo.gl/4tJ32G, which expects to deliver browser keyboard shortcuts to the web pages. BUG=680809 ========== to ========== Revert 3c7af99, but keep only IsReservedCommandOrKey change Change https://chromium.googlesource.com/chromium/src/+/3c7af99a93f4b4837b2fbee5cb66... impacts both keyboard shortcut reservation and enable / disable of the commands, while the later one is not expected. So this change partially reverts the original change. The intent to implement is https://goo.gl/4tJ32G, which expects to deliver browser keyboard shortcuts to the web pages. BUG=680809 ==========
zijiehe@chromium.org changed reviewers: + msw@chromium.org
lgtm, but I hope you'll keep the enum->bool change intact. https://codereview.chromium.org/2698013004/diff/1/chrome/browser/ui/browser_c... File chrome/browser/ui/browser_command_controller.cc (right): https://codereview.chromium.org/2698013004/diff/1/chrome/browser/ui/browser_c... chrome/browser/ui/browser_command_controller.cc:93: enum WindowState { I appreciated the removal of this enum; feel free to leave that intact.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run
Patchset #2 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
That will also make this change simpler. https://codereview.chromium.org/2698013004/diff/1/chrome/browser/ui/browser_c... File chrome/browser/ui/browser_command_controller.cc (right): https://codereview.chromium.org/2698013004/diff/1/chrome/browser/ui/browser_c... chrome/browser/ui/browser_command_controller.cc:93: enum WindowState { On 2017/02/16 00:48:53, msw wrote: > I appreciated the removal of this enum; feel free to leave that intact. Done.
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by zijiehe@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487225521528710,
"parent_rev": "992433e26b7b5abd3ff5d584501e6169bbcab16c", "commit_rev":
"13207802645e9185311993151707c56d28787ff7"}
Message was sent while issue was closed.
Description was changed from ========== Revert 3c7af99, but keep only IsReservedCommandOrKey change Change https://chromium.googlesource.com/chromium/src/+/3c7af99a93f4b4837b2fbee5cb66... impacts both keyboard shortcut reservation and enable / disable of the commands, while the later one is not expected. So this change partially reverts the original change. The intent to implement is https://goo.gl/4tJ32G, which expects to deliver browser keyboard shortcuts to the web pages. BUG=680809 ========== to ========== Revert 3c7af99, but keep only IsReservedCommandOrKey change Change https://chromium.googlesource.com/chromium/src/+/3c7af99a93f4b4837b2fbee5cb66... impacts both keyboard shortcut reservation and enable / disable of the commands, while the later one is not expected. So this change partially reverts the original change. The intent to implement is https://goo.gl/4tJ32G, which expects to deliver browser keyboard shortcuts to the web pages. BUG=680809 Review-Url: https://codereview.chromium.org/2698013004 Cr-Commit-Position: refs/heads/master@{#450894} Committed: https://chromium.googlesource.com/chromium/src/+/13207802645e9185311993151707... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/13207802645e9185311993151707... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
