Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2698003002:
Heap Profiler: Avoid splitting PartitionAlloc / BlinkGC type names by comma (Closed)
DescriptionHeap Profiler: Avoid splitting PartitionAlloc / BlinkGC type names by comma
BUG=
Review-Url: https://codereview.chromium.org/2698003002
Cr-Commit-Position: refs/heads/master@{#470681}
Committed: https://chromium.googlesource.com/chromium/src/+/cb0276c1cd972c33c68a04e2f17e6444ce520d19
Patch Set 1 #
Total comments: 1
Messages
Total messages: 21 (13 generated)
Description was changed from ========== Quick hack. BUG= ========== to ========== Should not split PartitionAlloc / BlinkGC type names by comma BUG= ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== Should not split PartitionAlloc / BlinkGC type names by comma BUG= ========== to ========== Heap Profiler: Avoid splitting PartitionAlloc / BlinkGC type names by comma BUG= ==========
The CQ bit was checked by tasak@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tasak@google.com changed reviewers: + primiano@chromium.org, ssid@chromium.org
Would you review this CL?
> Would you review this CL? Yes :) Yeah. I think this is a consequence of having hacked the type system for things like files and namespaces. we should rationalize it at some point. in the meantime this CL LGTM as a stopgap. Thanks for fixing this tasak! Also thanks for fixing the typo. https://codereview.chromium.org/2698003002/diff/20001/base/trace_event/heap_p... File base/trace_event/heap_profiler_type_name_deduplicator.cc (left): https://codereview.chromium.org/2698003002/diff/20001/base/trace_event/heap_p... base/trace_event/heap_profiler_type_name_deduplicator.cc:29: size_t last_seperator = result.find_last_of("\\/"); LOL, how much damage did a typo + code/paste :)
Yeah, we should remove the trace event categories from the type names. It is no longer useful after other recent changes. this lgtm.
The CQ bit was checked by tasak@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by primiano@chromium.org
On 2017/05/10 07:47:23, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) Looks like an infra failure. let me retick this for you.
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494441489157950,
"parent_rev": "05bbc16200b82e786110bd6ff3592fd29d4edf68", "commit_rev":
"cb0276c1cd972c33c68a04e2f17e6444ce520d19"}
Message was sent while issue was closed.
Description was changed from ========== Heap Profiler: Avoid splitting PartitionAlloc / BlinkGC type names by comma BUG= ========== to ========== Heap Profiler: Avoid splitting PartitionAlloc / BlinkGC type names by comma BUG= Review-Url: https://codereview.chromium.org/2698003002 Cr-Commit-Position: refs/heads/master@{#470681} Committed: https://chromium.googlesource.com/chromium/src/+/cb0276c1cd972c33c68a04e2f17e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/cb0276c1cd972c33c68a04e2f17e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
