[Offline Pages] Make prerenderer notify us of network progress.

[Offline Pages] Make prerenderer notify us of network progress.

Today, Prerenderer is made aware of bytes that are loaded when each
resource finishes, but does not expose it to observers of
PrerenderContents and friends.  This change allows us to track
coarse-grained progress on background downloads.

BUG=681269

[dewittj, 2017-02-15 00:47:14]

dewittj@chromium.org changed reviewers:
+ petewil@chromium.org

[dewittj, 2017-02-15 00:47:15]

NOT READY FOR REVIEW
- except by pete :) -

Here's my basic idea for getting progress, please skim it and let me know what
you think.

[Pete Williamson, 2017-02-15 01:17:45]

https://codereview.chromium.org/2697963002/diff/1/chrome/browser/android/offl...
File chrome/browser/android/offline_pages/prerender_adapter.h (right):

https://codereview.chromium.org/2697963002/diff/1/chrome/browser/android/offl...
chrome/browser/android/offline_pages/prerender_adapter.h:43: // Signals that a
resource finished loading and altered the running byte
is bytes a cumulative total of bytes loaded, or new bytes since last callback?

https://codereview.chromium.org/2697963002/diff/1/chrome/browser/android/offl...
File chrome/browser/android/offline_pages/prerender_adapter_unittest.cc (right):

https://codereview.chromium.org/2697963002/diff/1/chrome/browser/android/offl...
chrome/browser/android/offline_pages/prerender_adapter_unittest.cc:172: void
PrerenderAdapterTest::OnNetworkBytesChanged(int64_t bytes) {}
Might be good to add an actual test before we send it out for wider review.

[dewittj, 2017-02-17 22:55:13]

Description was changed from

==========
[Offline Pages] Make prerenderer notify us of network progress.

BUG=
==========

to

==========
[Offline Pages] Make prerenderer notify us of network progress.

Today, Prerenderer is made aware of bytes that are loaded when each resource
finishes, but does not expose it to observers of PrerenderContents and friends. 
This change allows us to track coarse-grained progress on background downloads.

BUG=681269
==========

[dewittj, 2017-02-17 22:55:13]

dewittj@chromium.org changed reviewers:
+ pasko@chromium.org

[dewittj, 2017-02-17 22:57:19]

Description was changed from

==========
[Offline Pages] Make prerenderer notify us of network progress.

Today, Prerenderer is made aware of bytes that are loaded when each resource
finishes, but does not expose it to observers of PrerenderContents and friends. 
This change allows us to track coarse-grained progress on background downloads.

BUG=681269
==========

to

==========
[Offline Pages] Make prerenderer notify us of network progress.

Today, Prerenderer is made aware of bytes that are loaded when each
resource finishes, but does not expose it to observers of
PrerenderContents and friends.  This change allows us to track
coarse-grained progress on background downloads.

BUG=681269
==========

[dewittj, 2017-02-17 23:20:15]

pasko: please take a brief look.  I don't have tests yet because I'm hoping to
get some input about general direction from you before I go much further.

Thanks!

https://codereview.chromium.org/2697963002/diff/1/chrome/browser/android/offl...
File chrome/browser/android/offline_pages/prerender_adapter.h (right):

https://codereview.chromium.org/2697963002/diff/1/chrome/browser/android/offl...
chrome/browser/android/offline_pages/prerender_adapter.h:43: // Signals that a
resource finished loading and altered the running byte
On 2017/02/15 01:17:45, Pete Williamson wrote:
> is bytes a cumulative total of bytes loaded, or new bytes since last callback?

This is a cumulative total.  Will update the comment.

[dewittj, 2017-02-19 20:52:01]

The CQ bit was checked by dewittj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-19 20:52:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dewittj, 2017-02-19 20:52:31]

dewittj@chromium.org changed reviewers:
+ dimich@chromium.org

[dewittj, 2017-02-19 20:52:47]

Added a few tests.  +dimich who will take this over while I'm out.

[commit-bot: I haz the power, 2017-02-19 20:53:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-19 20:53:56]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[pasko, 2017-02-20 16:52:15]

the approach sounds good on prerender side

[Dmitry Titov, 2017-02-22 00:12:42]

I'm taking it over per agreement with Justin while he's OOO.
Because I'm not an original uploader, I've created a new issue: 
https://codereview.chromium.org/2711693002

This issue is now closed, lets continue on that new one!