Remove incorrect optimization in LevelDBWrapperImpl::DeleteAll().

Remove incorrect optimization in LevelDBWrapperImpl::DeleteAll().

Observers should only be informed of a DeleteAll if something was
actually deleted. In order to do that, DeleteAll always has to try
loading any existing data before deleting.

BUG=586194
Review-Url: https://codereview.chromium.org/2697953002
Cr-Commit-Position: refs/heads/master@{#450823}
Committed: https://chromium.googlesource.com/chromium/src/+/30ff3ed98b0ec1beaab7f884ece7eedb7387888a

[Marijn Kruisselbrink, 2017-02-15 00:37:46]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 00:39:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 00:44:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 00:44:05]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Marijn Kruisselbrink, 2017-02-15 01:09:12]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 01:10:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-02-15 01:16:35]

mek@chromium.org changed reviewers:
+ jam@chromium.org, michaeln@chromium.org

[commit-bot: I haz the power, 2017-02-15 03:34:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 03:34:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jam, 2017-02-15 17:08:16]

lgtm

[Marijn Kruisselbrink, 2017-02-15 17:59:16]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 17:59:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-02-15 18:58:16]

The CQ bit was unchecked by mek@chromium.org

[Marijn Kruisselbrink, 2017-02-15 18:58:19]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2017-02-15 18:58:20]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2697953002/#ps60001
(title: "fix web platform test")

[commit-bot: I haz the power, 2017-02-15 18:58:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 20:37:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 20:37:07]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Marijn Kruisselbrink, 2017-02-15 21:19:05]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2017-02-15 21:20:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 22:52:21]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487193545684040,
"parent_rev": "81217a22a1dc79485433f211e35eaca71167a369", "commit_rev":
"30ff3ed98b0ec1beaab7f884ece7eedb7387888a"}

[commit-bot: I haz the power, 2017-02-15 22:53:06]

Description was changed from

==========
Remove incorrect optimization in LevelDBWrapperImpl::DeleteAll().

Observers should only be informed of a DeleteAll if something was
actually deleted. In order to do that, DeleteAll always has to try
loading any existing data before deleting.

BUG=586194
==========

to

==========
Remove incorrect optimization in LevelDBWrapperImpl::DeleteAll().

Observers should only be informed of a DeleteAll if something was
actually deleted. In order to do that, DeleteAll always has to try
loading any existing data before deleting.

BUG=586194

Review-Url: https://codereview.chromium.org/2697953002
Cr-Commit-Position: refs/heads/master@{#450823}
Committed:
https://chromium.googlesource.com/chromium/src/+/30ff3ed98b0ec1beaab7f884ece7...
==========

[commit-bot: I haz the power, 2017-02-15 22:53:08]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/30ff3ed98b0ec1beaab7f884ece7...