chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java - Issue 2697933002: Remove factory methods from ChromeApplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java

Issue 2697933002: Remove factory methods from ChromeApplication. (Closed)

Patch Set: Add some comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java » ('j') | chrome/android/java_sources.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java

index 4b7beb7b38b5f9543bdde51b3621bd764d732827..65ec2864ddbdc7ed36470de08675490773c8e156 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java

@@ -16,7 +16,7 @@ import org.chromium.base.ContextUtils;

import org.chromium.base.Log;

import org.chromium.base.metrics.CachedMetrics.EnumeratedHistogramSample;

import org.chromium.base.metrics.CachedMetrics.TimesHistogramSample;

-import org.chromium.chrome.browser.ChromeApplication;

+import org.chromium.chrome.browser.AppGlobals;

import org.chromium.chrome.browser.IntentHandler;

import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.externalnav.ExternalNavigationDelegateImpl;

@@ -103,8 +103,7 @@ public class InstantAppsHandler {

public static InstantAppsHandler getInstance() {

synchronized (INSTANCE_LOCK) {

if (sInstance == null) {

- Context appContext = ContextUtils.getApplicationContext();

- sInstance = ((ChromeApplication) appContext).createInstantAppsHandler();

+ sInstance = AppGlobals.get().createInstantAppsHandler();

}

return sInstance;