chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java - Issue 2697933002: Remove factory methods from ChromeApplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java

Issue 2697933002: Remove factory methods from ChromeApplication. (Closed)

Patch Set: Add some comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/help/HelpAndFeedback.java » ('j') | chrome/android/java_sources.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java b/chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java

index 6983bca34a18f93d55ab23d7e46bec12c04f3fd1..d2fa2c722f68ab067707930cbcbe2a42b7127b31 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/gsa/GSAServiceClient.java

@@ -27,7 +27,7 @@ import org.chromium.base.TraceEvent;

import org.chromium.base.VisibleForTesting;

import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.base.metrics.RecordHistogram;

-import org.chromium.chrome.browser.ChromeApplication;

+import org.chromium.chrome.browser.AppGlobals;

import java.util.List;

@@ -175,8 +175,7 @@ public class GSAServiceClient {

mHandler = new IncomingHandler();

mMessenger = new Messenger(mHandler);

mConnection = new GSAServiceConnection();

- mGsaHelper = ((ChromeApplication) mContext.getApplicationContext())

- .createGsaHelper();

+ mGsaHelper = AppGlobals.get().createGsaHelper();

}

/**