Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: remoting/webapp/html/client_plugin.html

Issue 269793002: Fix <video> positioning for the MediaSource-based rendering (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/webapp/main.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/html/client_plugin.html
diff --git a/remoting/webapp/html/client_plugin.html b/remoting/webapp/html/client_plugin.html
index af375ae3ae6e5dca024164888fb5ca9a588b97f3..a90b8db348c6fa93de19feec08ea4813dafd8a82 100644
--- a/remoting/webapp/html/client_plugin.html
+++ b/remoting/webapp/html/client_plugin.html
@@ -4,8 +4,12 @@ Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file.
-->
<div class="vertically-centered">
- <div id="video-container">
- <video id="mediasource-video-output"></video>
- <div id="client-plugin-container" class="horizontally-centered"></div>
+ <div class="vertically-centered-inner">
Jamie 2014/05/02 21:01:43 This class name is misleading; it's actually outsi
kelvinp 2014/05/02 22:08:03 Yes, can we simply add 100% on vertically-centered
Sergey Ulanov 2014/05/02 22:10:06 Done.
Sergey Ulanov 2014/05/02 22:19:22 Nope, tried that. It makes it impossible to scroll
+ <div class="horizontally-centered">
+ <div id="video-container">
Jamie 2014/05/02 21:01:43 Do we really need 4 containing divs to position th
Sergey Ulanov 2014/05/02 22:10:06 We need at least 3 divs: - one for vertial center
+ <video id="mediasource-video-output"></video>
+ <div id="client-plugin-container"></div>
+ </div>
</div>
+ </div>
</div>
« no previous file with comments | « no previous file | remoting/webapp/main.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698