remoting/webapp/html/client_plugin.html - Issue 269793002: Fix <video> positioning for the MediaSource-based rendering

Side by Side Diff: remoting/webapp/html/client_plugin.html

Issue 269793002: Fix <video> positioning for the MediaSource-based rendering (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!--	1 <!--

2 Copyright (c) 2014 The Chromium Authors. All rights reserved.	2 Copyright (c) 2014 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file.	4 found in the LICENSE file.

5 -->	5 -->

6 <div class="vertically-centered">	6 <div class="vertically-centered">

7 <div id="video-container">	7 <div class="vertically-centered-inner">
	Jamie 2014/05/02 21:01:43 This class name is misleading; it's actually outsi This class name is misleading; it's actually outside the the vertically-centered div. I would just name it 'full-width' (we already have a 'full-height' class). kelvinp 2014/05/02 22:08:03 Yes, can we simply add 100% on vertically-centered Show quoted text On 2014/05/02 21:01:43, Jamie wrote: > This class name is misleading; it's actually outside the the vertically-centered > div. I would just name it 'full-width' (we already have a 'full-height' class). Yes, can we simply add 100% on vertically-centered? Also, please make sure that you can still connect to the host when the browser zoom level is 100% and scroll bar are present when the host has a higher resolution than the client Sergey Ulanov 2014/05/02 22:10:06 Done. Show quoted text On 2014/05/02 21:01:43, Jamie wrote: > This class name is misleading; it's actually outside the the vertically-centered > div. I would just name it 'full-width' (we already have a 'full-height' class). Done. Sergey Ulanov 2014/05/02 22:19:22 Nope, tried that. It makes it impossible to scroll Show quoted text On 2014/05/02 22:08:03, kelvinp wrote: > On 2014/05/02 21:01:43, Jamie wrote: > > This class name is misleading; it's actually outside the the > vertically-centered > > div. I would just name it 'full-width' (we already have a 'full-height' > class). > > Yes, can we simply add 100% on vertically-centered? Nope, tried that. It makes it impossible to scroll to the top, when the remote screen is taller. Show quoted text > Also, please make sure that you can still connect to the host when the browser > zoom level is 100% and scroll bar are present when the host has a higher > resolution than the client yes, still works.
8 <video id="mediasource-video-output"></video>	8 <div class="horizontally-centered">

9 <div id="client-plugin-container" class="horizontally-centered"></div>	9 <div id="video-container">
	Jamie 2014/05/02 21:01:43 Do we really need 4 containing divs to position th Do we really need 4 containing divs to position these elements correctly? Can we get away with just 2? I suspect that horizontal and vertical centering need separate divs, but any other properties you want to enforce can probably be done with additional classes on those two divs. Sergey Ulanov 2014/05/02 22:10:06 We need at least 3 divs: - one for vertial center Show quoted text On 2014/05/02 21:01:43, Jamie wrote: > Do we really need 4 containing divs to position these elements correctly? Can we > get away with just 2? I suspect that horizontal and vertical centering need > separate divs, but any other properties you want to enforce can probably be done > with additional classes on those two divs. We need at least 3 divs: - one for vertial centering - one for horizontal centering - one to enclose <video> and the plugin I tried removing the second one (vertically-centered-inner), but couldn't get it to work properly.
	10 <video id="mediasource-video-output"></video>

	11 <div id="client-plugin-container"></div>

	12 </div>

10 </div>	13 </div>

	14 </div>

11 </div>	15 </div>

OLD	NEW

« no previous file with comments | « no previous file | remoting/webapp/main.css » ('j') | no next file with comments »